Skip to content

test: increase coverage of console - #11653

Closed
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:test/console-coverage
Closed

test: increase coverage of console#11653
DavidCai1111 wants to merge 1 commit into
nodejs:masterfrom
DavidCai1111:test/console-coverage

Conversation

@DavidCai1111

@DavidCai1111DavidCai1111 commented Mar 2, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2017
@cjihrig

cjihrig commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

Related: #11531

@hiroppyhiroppy added the console Issues and PRs related to the console subsystem. label Mar 2, 2017
@claudiorodriguez

claudiorodriguez commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/6661/

mhdawson
mhdawson approved these changes Mar 2, 2017
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Mar 6, 2017

Copy link
Copy Markdown
Member

New CI run as there were failures and can't see details any more: https://ci.nodejs.org/job/node-test-pull-request/6734/

@fhinkel

fhinkel commented Mar 9, 2017

Copy link
Copy Markdown
Member

Thanks, landed in 74bd314.

@fhinkelfhinkel closed this Mar 9, 2017
fhinkel pushed a commit that referenced this pull request Mar 9, 2017
@davidtaikocha@fhinkel
test: increase coverage of console
74bd314
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
@davidtaikochaItalo A. Casas
test: increase coverage of console
a98d963
PR-URL: nodejs#11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@italoacasasitaloacasas mentioned this pull request Mar 13, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@davidtaikocha@jungx098
test: increase coverage of console
7ac0db1
PR-URL: nodejs#11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
@davidtaikocha@MylesBorins
test: increase coverage of console
d0d9c7c
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@davidtaikocha@MylesBorins
test: increase coverage of console
5a93eab
PR-URL: #11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@davidtaikocha@andrew749
test: increase coverage of console
72d357c
PR-URL: nodejs/node#11653
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@alisccoaliscco mentioned this pull request Jun 23, 2023
Open
@leonardoadameleonardoadame mentioned this pull request Dec 1, 2023
Open
@alisccoaliscco mentioned this pull request Dec 2, 2023
Open
@alisccoaliscco mentioned this pull request Jan 9, 2024
Open
@leonardoadameleonardoadame mentioned this pull request Jan 10, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+4 more reviewers
@thefourtheyethefourtheyethefourtheye approved these changes
@hiroppyhiroppyhiroppy approved these changes
@claudiorodriguezclaudiorodriguezclaudiorodriguez approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

consoleIssues and PRs related to the console subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@DavidCai1111@cjihrig@claudiorodriguez@mhdawson@fhinkel@jasnell@thefourtheye@hiroppy@MylesBorins@nodejs-github-bot@davidtaikocha