Skip to content

Add missing new for errors lib/*.js - #1246

Closed
nstepien wants to merge 2 commits into
nodejs:v1.xfrom
nstepien:patch-1
Closed

Add missing new for errors lib/*.js#1246
nstepien wants to merge 2 commits into
nodejs:v1.xfrom
nstepien:patch-1

Conversation

@nstepien

@nstepiennstepien commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

It doesn't break anything, but it does add an unwanted line in the stack trace.

@petkaantonov

petkaantonov commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

@mscdexmscdex added the crypto Issues and PRs related to the crypto subsystem. label Mar 24, 2015
@nstepien

nstepien commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Now that I look at it, there's a bunch of similar throw Error(...) code, maybe I should send a more complete PR?

@benjamingr

benjamingr commented Mar 24, 2015

Copy link
Copy Markdown
Member

There should probably be an established policy of whether or not to include new before errors.

@petkaantonov

petkaantonov commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

Seems a no-brainer to me, when not including new you potentially lose 1 useful frame and add 1 useless frame

@nstepien
Add missing new for errors lib/*.js
9f22989
Not including `new` adds a useless frame and removes a potentially useful frame.
@nstepien

nstepien commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

Changed my commit to fix the other cases I could find in lib where errors were created without new.
PTAL.

@nstepiennstepien changed the title Add missing new for a TypeError in crypto.jsAdd missing new for errors lib/*.jsMar 24, 2015
@petkaantonov

petkaantonov commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

changing all error constructor calls LGTM

@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

There should probably be an established policy of whether or not to include new before errors.

I think instead of writing down every little rule, we should just enforce these through a linter.

@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

Also, LGTM

@Fishrock123Fishrock123 removed the crypto Issues and PRs related to the crypto subsystem. label Mar 24, 2015
brendanashworth
brendanashworth reviewed Mar 24, 2015
View reviewed changes
Comment threadlib/dns.js Outdated

@brendanashworthbrendanashworthMar 24, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is now 82 characters long, could you wrap it?

@brendanashworth

brendanashworth commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

One comment, otherwise LGTM.

@nstepien

nstepien commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

@brendanashworth
There you go.

brendanashworth pushed a commit that referenced this pull request Mar 24, 2015
@nstepien@brendanashworth
lib: add missing new for errors lib/*.js
1832743
Not including `new` adds a useless frame and removes a potentially
useful frame.
PR-URL: #1246
Reviewed-By: Petka Antonov <petka_antonov@hotmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@brendanashworth

brendanashworth commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

Thanks @MayhemYDG, this has been merged in 1832743!

@nstepien
nstepien deleted the patch-1 branch March 24, 2015 19:45
@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

Noticed this commit got merged with a nickname instead of a real name as git user.name, which isn't ideal, especially when it comes to AUTHORS.

It's too late now to fix that, and everyone who LGTM'd that is probably guilty, including me 😇.

Just something to keep an look out in the future @iojs/collaborators.

@nstepien

nstepien commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

@silverwind
Mmh, to my defense CONTRIBUTING.md isn't 100% clear on that one.

$ git config --global user.name "J. Random User"

"Random User" sounds like a nickname.

Either way you got my name in my email address.

@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

Yeah, that's partially at fault too. I'll mention it on the next AUTHORS update.

@silverwindsilverwind mentioned this pull request Mar 24, 2015
Closed
@rvaggrvagg mentioned this pull request Mar 25, 2015
Closed
@tellnes

tellnes commented Mar 27, 2015

Copy link
Copy Markdown
Contributor

This also changes lib/punycode.js which is maintained externally.

@nstepiennstepien mentioned this pull request Mar 27, 2015
Closed
mathiasbynens pushed a commit to mathiasbynens/punycode.js that referenced this pull request Mar 27, 2015
@nstepien@mathiasbynens
Add new to RangeError
702cc2d
Although it is optional, when not including `new` you potentially lose a single useful frame in the stack trace and add a useless frame.
nodejs/node#1246Closes#32.
@rlidwka

rlidwka commented Mar 29, 2015

Copy link
Copy Markdown
Contributor

Maybe it's better to report this to v8 team, so they could make new Error() and Error() behaviors identical?

@Fishrock123Fishrock123 mentioned this pull request Apr 9, 2015
Closed
@ChALkeRChALkeR mentioned this pull request Jan 25, 2016
Closed
benjamingr added a commit to benjamingr/io.js that referenced this pull request Mar 27, 2016
@benjamingr
punycode: update to 1.4.1
193b452
Update punycode to the latest released version. This is mainly in
order to further reduce the maintenance burden. In
nodejs#1246 a fix introducing `new` to
errors was introduced and it has since been ported back to the
punycode library.
This puts Node back in sync with the library itself so it can receive
future fixes and updates directly.
PR-URL:
Reviewed-By:
Reviewed-By:
@benjamingrbenjamingr mentioned this pull request Mar 27, 2016
Closed
@MarcelRaschkeMarcelRaschke mentioned this pull request Nov 5, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@nstepien@petkaantonov@benjamingr@silverwind@brendanashworth@tellnes@rlidwka@mscdex@Fishrock123