Skip to content

doc: clarify real name requirement in CONTRIBUTING.md - #1250

Closed
silverwind wants to merge 1 commit into
nodejs:v1.xfrom
silverwind:contributing-real-name
Closed

doc: clarify real name requirement in CONTRIBUTING.md#1250
silverwind wants to merge 1 commit into
nodejs:v1.xfrom
silverwind:contributing-real-name

Conversation

@silverwind

@silverwindsilverwind commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

This should hopefully make it more clear that git's user.name should be set to the real name before committing a pull request. I'm open to suggestions of witty placeholder names ;)

related: #1246
cc: @MayhemYDG

@nstepien

nstepien commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

👍

@Fishrock123

Fishrock123 commented Mar 24, 2015

Copy link
Copy Markdown
Contributor

LGTM

@silverwindsilverwind added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. and removed child_process Issues and PRs related to the child_process subsystem. labels Mar 24, 2015
@silverwindsilverwind changed the title doc: add real name requirement to CONTRIBUTING.mddoc: clarify real name requirement in CONTRIBUTING.mdMar 24, 2015
@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

I think this is a pretty straightforward improvement, going to merge it in right ahead.

@silverwindsilverwind self-assigned this Mar 24, 2015
silverwind added a commit that referenced this pull request Mar 24, 2015
@silverwind
doc: clarify real name requirement
4e9bf93
CONTRIBUTING.md didn't make our rule for requiring real names from
contributors clear enough. This commit shall clarify that part.
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #1250
@silverwind

silverwind commented Mar 24, 2015

Copy link
Copy Markdown
ContributorAuthor

merged in 4e9bf93

@rvaggrvagg mentioned this pull request Mar 25, 2015
Closed
@rvagg

rvagg commented Mar 25, 2015

Copy link
Copy Markdown
Member

Actually I'm -1 on this, it's not straight forward, some people prefer to use pseudonyms and there's no reason to force a real name out of these people, this change could be interpreted as policy.

See #606 for an example for this.

@silverwind

silverwind commented Mar 25, 2015

Copy link
Copy Markdown
ContributorAuthor

Ah, I was under the impression it was a hard rule as I was requested to change my user.name on my first contribution (#483 (comment)). If this is a remnant from node.js days, I'm all for dropping it.

@Fishrock123

Fishrock123 commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

@rvagg should this be reverted?

@aredridel

aredridel commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

Please. Real names are slippery beasts and I really don't want to use the one that is still my legal name. There is no reason to.

@Fishrock123Fishrock123 mentioned this pull request Mar 26, 2015
Closed
@Fishrock123Fishrock123 mentioned this pull request Apr 9, 2015
Closed
@MarcelRaschkeMarcelRaschke mentioned this pull request Nov 5, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@silverwindsilverwind

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind@nstepien@Fishrock123@rvagg@aredridel