Uh oh!
There was an error while loading. Please reload this page.
debugger: remove obsolete _debug_agent.js - #12582
Closed
Trott wants to merge 1 commit into
Closed
Conversation
With _debugger.js removed, _debug_agent.js appears to be unnecessary.
Trott
commented
Apr 22, 2017
MemberAuthor
Trott
commented
Apr 22, 2017
MemberAuthor
Assuming I'm not wrong about this being removable, there's probably some related C++ code that can go as well. |
benjamingr
approved these changes
Apr 22, 2017
benjamingr
left a comment
Member
There was a problem hiding this comment.
CI is green, change seems good.
bnoordhuis
approved these changes
Apr 22, 2017
bnoordhuis
left a comment
Member
There was a problem hiding this comment.
LGTM
there's probably some related C++ code that can go as well.
I was going to look at that next week; there is quite a bit of code that can be deleted. Doesn't need to hold up this PR though.
cjihrig
approved these changes
Apr 22, 2017
jasnell
approved these changes
Apr 24, 2017
gibfahn
approved these changes
Apr 24, 2017
jasnell pushed a commit
that referenced
this pull request
Apr 24, 2017
With _debugger.js removed, _debug_agent.js appears to be unnecessary. PR-URL: #12582 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
jasnell
commented
Apr 24, 2017
Member
Landed in 549e81b |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With _debugger.js removed, _debug_agent.js appears to be unnecessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
debugger test