Skip to content

deps: upgrade libuv to 1.12.0 - #13306

Merged
cjihrig merged 3 commits into
nodejs:masterfrom
cjihrig:uv
Jun 7, 2017
Merged

deps: upgrade libuv to 1.12.0#13306
cjihrig merged 3 commits into
nodejs:masterfrom
cjihrig:uv

Conversation

@cjihrig

@cjihrigcjihrig commented May 30, 2017

Copy link
Copy Markdown
Contributor

If anyone knows of any Node.js issues that are resolved by this release, please link them here so they can be added to the commit metadata, and closed on landing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. libuv Issues and PRs related to the libuv dependency or the uv binding. labels May 30, 2017
@cjihrig
cjihrig requested review from saghul and removed request for saghulMay 30, 2017 17:22
@BridgeAR

BridgeAR commented May 30, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Solves #12853. As far as I see it, it's the only issue closed by the upgrade.

mscdex
mscdex reviewed May 30, 2017
View reviewed changes
Comment threaddeps/uv/.github/ISSUE_TEMPLATE.md Outdated

@mscdexmscdexMay 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this file can be ignored?

@Fishrock123

Fishrock123 commented May 30, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

I believe one of the oldest still-open issues, #854, is fixed by this?

Assuming unix: remove FSEventStreamFlushSync() call is in this release.

bnoordhuis
bnoordhuis approved these changes May 30, 2017
View reviewed changes

@bnoordhuisbnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Anyone have opinions on whether to gitignore the uvbook files in docs/code and docs/src/guide? It adds another ~100 kB to the tarball (240 kB uncompressed) and I don't expect many people will look at it.

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

The support code for older systems is still there but going forward we won't bend over backwards to keep it in working shape.

@jasnell

jasnell commented May 30, 2017

Copy link
Copy Markdown
Member

+1 to ignoring the uvbook files

jasnell
jasnell approved these changes May 30, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM but I'd like to see a CITGM run before this lands.

mhdawson
mhdawson approved these changes May 31, 2017
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp approval from me as well provided CI passes.

@cjihrig

cjihrig commented Jun 1, 2017

Copy link
Copy Markdown
ContributorAuthor

@bnoordhuis should the uvbook be explicitly added to .gitignore, or just not checked in?

@bnoordhuis

bnoordhuis commented Jun 1, 2017

Copy link
Copy Markdown
Member

@cjihrig I'd add it to the .gitignore, that prevents accidental check-ins in the future.

@cjihrig
cjihrigforce-pushed the uv branch 2 times, most recently from cf680b8 to 59b0847CompareJune 1, 2017 17:03
@cjihrig

cjihrig commented Jun 1, 2017

Copy link
Copy Markdown
ContributorAuthor

Removed the uvbook and .github folders. PTAL

@richardlau

richardlau commented Jun 1, 2017

Copy link
Copy Markdown
Member

Important change: this version of libuv raises the minimum supported version from linux 2.6.18 + glibc 2.5 to linux 2.6.32 + glibc 2.12.

We should also raise Node.js' minimum supported levels in BUILDING.md to match.

@cjihrig
cjihrigforce-pushed the uv branch 2 times, most recently from 871ed57 to 9b40352CompareJune 5, 2017 01:43
@cjihrig

cjihrig commented Jun 5, 2017

Copy link
Copy Markdown
ContributorAuthor

Added a commit to update BUILDING.md.

@bnoordhuis

bnoordhuis commented Jun 5, 2017

Copy link
Copy Markdown
Member

Still LGTM. The raised baseline might become non-academic in the future, see libuv/libuv#1372.

@Fishrock123

Fishrock123 commented Jun 5, 2017

Copy link
Copy Markdown
Contributor

@cjihrig could you please move the .gitignore change into it's own commit?

@cjihrig

cjihrig commented Jun 5, 2017

Copy link
Copy Markdown
ContributorAuthor

Moved to separate commit. CI: https://ci.nodejs.org/job/node-test-pull-request/8482/

@cjihrig

cjihrig commented Jun 5, 2017

Copy link
Copy Markdown
ContributorAuthor

CI seemed good. Ran CITGM (https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/854/). Can someone help interpreting the output?

@gibfahn

gibfahn commented Jun 5, 2017

Copy link
Copy Markdown
Member

cc/ @nodejs/citgm

@bricssbricss mentioned this pull request Jun 5, 2017
Closed
cjihrig added 2 commits June 7, 2017 09:30
@cjihrig
deps: upgrade libuv to 1.12.0
edd5419
Fixes: nodejs#12853Fixes: nodejs#854
PR-URL: nodejs#13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig
doc: update linux supported versions
29b63a1
The libuv 1.12.0 update bumped the minimum supported version
of linux + glibc. This commit updates BUILDING.md to reflect
the new values.
PR-URL: nodejs#13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
jasnell added a commit to jasnell/node that referenced this pull request Jun 7, 2017
@jasnell
2017-05-07, Version 8.1.0 (Current)
a4fb427
* **Async Hooks**
* When one `Promise` leads to the creation of a new `Promise`, the parent
`Promise` will be identified as the trigger
[[`135f4e6643`](nodejs@135f4e6643)]
[nodejs#13367](nodejs#13367).
* **Dependencies**
* libuv has been updated to 1.12.0
[[`968596ec77`](nodejs@968596ec77)]
[nodejs#13306](nodejs#13306).
* npm has been updated to 5.0.3
[[`ffa7debd7a`](nodejs@ffa7debd7a)]
[nodejs#13487](nodejs#13487).
* **File system**
* The `fs.exists()` function now works correctly with `util.promisify()`
[[`6e0eccd7a1`](nodejs@6e0eccd7a1)]
[nodejs#13316](nodejs#13316).
* fs.Stats times are now also available as numbers
[[`c756efb25a`](nodejs@c756efb25a)]
[nodejs#13173](nodejs#13173).
* **Inspector**
* It is now possible to bind to a random port using `--inspect=0`
[[`cc6ec2fb27`](nodejs@cc6ec2fb27)]
[nodejs#5025](nodejs#5025).
* **Zlib**
* A regression in the Zlib module that made it impossible to properly
subclasses `zlib.Deflate` and other Zlib classes has been fixed.
[[`6aeb555cc4`](nodejs@6aeb555cc4)]
[nodejs#13374](nodejs#13374).
rvagg pushed a commit that referenced this pull request Jun 8, 2017
@jasnell@rvagg
2017-05-07, Version 8.1.0 (Current)
f6fc46e
* **Async Hooks**
* When one `Promise` leads to the creation of a new `Promise`, the parent
`Promise` will be identified as the trigger
[[`135f4e6643`](135f4e6643)]
[#13367](#13367).
* **Dependencies**
* libuv has been updated to 1.12.0
[[`968596ec77`](968596ec77)]
[#13306](#13306).
* npm has been updated to 5.0.3
[[`ffa7debd7a`](ffa7debd7a)]
[#13487](#13487).
* **File system**
* The `fs.exists()` function now works correctly with `util.promisify()`
[[`6e0eccd7a1`](6e0eccd7a1)]
[#13316](#13316).
* fs.Stats times are now also available as numbers
[[`c756efb25a`](c756efb25a)]
[#13173](#13173).
* **Inspector**
* It is now possible to bind to a random port using `--inspect=0`
[[`cc6ec2fb27`](cc6ec2fb27)]
[#5025](#5025).
* **Zlib**
* A regression in the Zlib module that made it impossible to properly
subclasses `zlib.Deflate` and other Zlib classes has been fixed.
[[`6aeb555cc4`](6aeb555cc4)]
[#13374](#13374).
rvagg pushed a commit that referenced this pull request Jun 8, 2017
@jasnell@rvagg
2017-05-07, Version 8.1.0 (Current)
d7f6919
* **Async Hooks**
* When one `Promise` leads to the creation of a new `Promise`, the parent
`Promise` will be identified as the trigger
[[`135f4e6643`](135f4e6643)]
[#13367](#13367).
* **Dependencies**
* libuv has been updated to 1.12.0
[[`968596ec77`](968596ec77)]
[#13306](#13306).
* npm has been updated to 5.0.3
[[`ffa7debd7a`](ffa7debd7a)]
[#13487](#13487).
* **File system**
* The `fs.exists()` function now works correctly with `util.promisify()`
[[`6e0eccd7a1`](6e0eccd7a1)]
[#13316](#13316).
* fs.Stats times are now also available as numbers
[[`c756efb25a`](c756efb25a)]
[#13173](#13173).
* **Inspector**
* It is now possible to bind to a random port using `--inspect=0`
[[`cc6ec2fb27`](cc6ec2fb27)]
[#5025](#5025).
* **Zlib**
* A regression in the Zlib module that made it impossible to properly
subclasses `zlib.Deflate` and other Zlib classes has been fixed.
[[`6aeb555cc4`](6aeb555cc4)]
[#13374](#13374).
@gibfahngibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorinsMylesBorins added backport-requested-v6.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 17, 2017
@MylesBorins

MylesBorins commented Jul 17, 2017

Copy link
Copy Markdown
Contributor

Can we get this backported to v6.x for a future semver minor

@bnoordhuisbnoordhuis mentioned this pull request Aug 16, 2017
Merged
2 tasks
@MylesBorins

MylesBorins commented Sep 19, 2017

Copy link
Copy Markdown
Contributor

@cjihrig@bnoordhuis do you see any issues with backporting this to v6.x? The minimal version of kernel + libc are slightly worrysome, but your comments appear to imply that it isn't a big deal.

@gibfahn

gibfahn commented Sep 19, 2017

Copy link
Copy Markdown
Member

Could we backport this version without backporting the supported versions update? @bnoordhuis you mentioned that it was academic for this release, and this is likely to be the last libuv update for 6.x.

@bnoordhuis

bnoordhuis commented Sep 19, 2017

Copy link
Copy Markdown
Member

None of the support code for old kernels was removed so yes, this is safe to back-port.

MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@cjihrig@MylesBorins
deps: upgrade libuv to 1.12.0
1ba3932
Fixes: #12853Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@cjihrig@MylesBorins
gitignore: add libuv book and GitHub template
e53ef05
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrigcjihrig mentioned this pull request Oct 16, 2017
Merged
2 tasks
@MylesBorinsMylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig@MylesBorins
deps: upgrade libuv to 1.12.0
3265840
Fixes: #12853Fixes: #854
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@cjihrig@MylesBorins
gitignore: add libuv book and GitHub template
3ac7690
PR-URL: #13306
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Nov 6, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
c6a2ec5
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
70dc6d5
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
@uttampawaruttampawar mentioned this pull request Jun 14, 2018
Closed
@uttampawar

uttampawar commented Jun 14, 2018

Copy link
Copy Markdown
Contributor

Is there a timeline when this can land? Thanks.

@cjihrig

cjihrig commented Jun 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Land where? Node 6 is the oldest supported release line and it has a newer version of libuv than this.

@uttampawar

uttampawar commented Jun 15, 2018

Copy link
Copy Markdown
Contributor

@cjihrig I thought that content of libuv/libuv#1372 is getting pulled in as part of this PR which I realized is not the case. I apologize for the confusion, it was misunderstanding on my part.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@santigimenosantigimenosantigimeno approved these changes
+2 more reviewers
@mscdexmscdexmscdex left review comments
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.libuvIssues and PRs related to the libuv dependency or the uv binding.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@cjihrig@BridgeAR@Fishrock123@jasnell@bnoordhuis@richardlau@gibfahn@MylesBorins@uttampawar@mscdex@santigimeno@mhdawson@nodejs-github-bot