Skip to content

src: --abort-on-uncaught-exception in NODE_OPTIONS - #13932

Merged
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:allow-abort-on-uncaught-exception-in-node-options
Jul 5, 2017
Merged

src: --abort-on-uncaught-exception in NODE_OPTIONS#13932
sam-github merged 1 commit into
nodejs:masterfrom
sam-github:allow-abort-on-uncaught-exception-in-node-options

Conversation

@sam-github

@sam-githubsam-github commented Jun 26, 2017

Copy link
Copy Markdown
Contributor

Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 26, 2017
@richardlau

richardlau commented Jun 26, 2017

Copy link
Copy Markdown
Member

Should it be added to test/parallel/test-cli-node-options.js?

richardlau
richardlau reviewed Jun 27, 2017
View reviewed changes
Comment threadsrc/node.cc Outdated

@richardlaurichardlauJun 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V8 options can use both - and _ (https://nodejs.org/api/cli.html#cli_v8_options), so we should cover the variants (same for --max_old_space_size).

richardlau
richardlau reviewed Jun 27, 2017
View reviewed changes
Comment threaddoc/api/cli.md Outdated

@richardlaurichardlauJun 27, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be listed as a V8 option like --max_old_space_size?

@sam-github
src: --abort-on-uncaught-exception in NODE_OPTIONS
c45df83
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
PR-URL: nodejs#13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github
sam-githubforce-pushed the allow-abort-on-uncaught-exception-in-node-options branch from bffc98b to c45df83CompareJuly 5, 2017 20:58
@sam-github
sam-github merged commit c45df83 into nodejs:masterJul 5, 2017
@sam-githubsam-github mentioned this pull request Jul 5, 2017
Closed
4 tasks
@sam-githubsam-github mentioned this pull request Jul 10, 2017
Closed
4 tasks
@sam-github
sam-github deleted the allow-abort-on-uncaught-exception-in-node-options branch July 10, 2017 23:31
addaleax pushed a commit that referenced this pull request Jul 11, 2017
@sam-github@addaleax
src: --abort-on-uncaught-exception in NODE_OPTIONS
106bc5c
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
PR-URL: #13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request Jul 11, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@sam-github@addaleax
src: --abort-on-uncaught-exception in NODE_OPTIONS
21ee4b1
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
PR-URL: #13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@sam-github@Fishrock123
src: --abort-on-uncaught-exception in NODE_OPTIONS
a4f67f9
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
PR-URL: #13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Aug 15, 2017

Copy link
Copy Markdown
Contributor

Should this have been semver-minor?

@sam-githubsam-github added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 16, 2017
@sam-github

sam-github commented Aug 16, 2017

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins yes, I just labelled it so

@sam-github

sam-github commented Aug 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Also, note that all the NODE_OPTIONS changes, including this one, are collected into a semver-minor backport PR: https://github.com/nodejs/node/pull/12677/commits

sam-github added a commit to sam-github/node that referenced this pull request Oct 11, 2017
@sam-github
src: --abort-on-uncaught-exception in NODE_OPTIONS
6e70c5c
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
PR-URL: nodejs#13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 16, 2017
@sam-github@MylesBorins
src: --abort-on-uncaught-exception in NODE_OPTIONS
a76c2ae
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
Backport-PR-URL: #12677
PR-URL: #13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@sam-github@MylesBorins
src: --abort-on-uncaught-exception in NODE_OPTIONS
cccf5a6
Allow --abort-on-uncaught-exception in NODE_OPTIONS, its useful to
enable for post-mortem debugging.
Backport-PR-URL: #12677
PR-URL: #13932
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2017
Merged
MylesBorins added a commit that referenced this pull request Nov 6, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
c6a2ec5
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
MylesBorins added a commit that referenced this pull request Nov 7, 2017
@MylesBorins
2017-11-07, Version 6.12.0 'Boron' (LTS)
70dc6d5
Notable Changes:
* assert:
- assert.fail() can now take one or two arguments (Rich Trott)
#12293
* crypto:
- add sign/verify support for RSASSA-PSS (Tobias Nießen)
#11705
* deps:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu)
#16691
- upgrade libuv to 1.15.0 (cjihrig)
#15745
- upgrade libuv to 1.14.1 (cjihrig)
#14866
- upgrade libuv to 1.13.1 (cjihrig)
#14117
- upgrade libuv to 1.12.0 (cjihrig)
#13306
* fs:
- Add support for fs.write/fs.writeSync(fd, buffer, cb) and
fs.write/fs.writeSync(fd, buffer, offset, cb) as documented
(Andreas Lind) #7856
* inspector:
- enable --inspect-brk (Refael Ackermann)
#12615
* process:
- add --redirect-warnings command line argument (James M Snell)
#10116
* src:
- allow CLI args in env with NODE_OPTIONS (Sam Roberts)
#12028)
- --abort-on-uncaught-exception in NODE_OPTIONS (Sam Roberts)
#13932
- allow --tls-cipher-list in NODE_OPTIONS (Sam Roberts)
#13172
- use SafeGetenv() for NODE_REDIRECT_WARNINGS (Sam Roberts)
#12677
* test:
- remove common.fail() (Rich Trott)
#12293
PR-URL: #16263
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sam-github@richardlau@MylesBorins@jasnell@cjihrig@nodejs-github-bot