Uh oh!
There was an error while loading. Please reload this page.
doc: add documentation on ICU - #13916
Conversation
vsemozhetbyt
commented
Jun 26, 2017
If it remains in the |
vsemozhetbyt
commented
Jun 26, 2017
There was a problem hiding this comment.
Please avoid use of informal pronouns like we in the docs... Also, this last sentence is a bit off for me... Perhaps:
Because it is expected that most Node.js users will make use of only a small portion
of ICU functionality, only a subset of the full ICU data set is provided by Node.js by
default. Several options are provided for customizing and expanding the ICU data set
either when building or running Node.js.
There was a problem hiding this comment.
Please avoid using informal pronouns like your in the docs.
There was a problem hiding this comment.
As above, please avoid using informal pronouns like you
TimothyGu
commented
Jun 27, 2017
@jasnell Comments are addressed. What are your thoughts on where this document should end up? |
TimothyGu
commented
Jul 5, 2017
I'll merge this tomorrow if there are no more comments. |
vsemozhetbyt
commented
Jul 5, 2017
Linter (you may need to rebase after the 15599cb): |
Not too big of a fan of the linter change, but changed. Linter CI: https://ci.nodejs.org/job/node-test-linter/10274/ |
vsemozhetbyt
commented
Jul 5, 2017
@TimothyGu It seems it is due to 7477f9b, but I wanted to be on safe side with updated tools) |
TimothyGu
commented
Jul 6, 2017
Landed in 6809429 |
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
commented
Aug 15, 2017
Is this applicable to v6.x? It is easy enough to land this but I want to ensure that it makes sense for the version of ICU that is embedded 6.x: 58.2 |
TimothyGu
commented
Aug 15, 2017
@MylesBorins Yep, most of the content is applicable to 6.x as well, but some things need to be changed (e.g. mentions of the WHATWG URL API as it doesn't exist in 6.x). |
PR-URL: nodejs#13916 Refs: nodejs#13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
PR-URL: #13916 Refs: #13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Adapted from the wiki article "Intl" by @srl295. Open to suggestions w.r.t. where this page belongs best, either here or on nodejs.org, but somewhere more permanent than a wiki.
Refs: #13644 (comment)
Checklist
Affected core subsystem(s)
doc