Uh oh!
There was an error while loading. Please reload this page.
[v6.x backport] doc: add documentation on ICU - #15353
Conversation
There was a problem hiding this comment.
Default v6.11.3 prints M01 for me (Windows 7 x64).
There was a problem hiding this comment.
Hmm, it's M01 for me on master as well but January on v6.x. Can you check the output after changing your LC_ALL environment variable to en_US?
There was a problem hiding this comment.
Output:
>setLC_ALL=en_US>setLC_ALLLC_ALL=en_US>node.6.11.3.v8-5.1.exe>constjanuary=newDate(9e8);>constenglish=newIntl.DateTimeFormat('en',{month: 'long'});>constspanish=newIntl.DateTimeFormat('es',{month: 'long'});>console.log(english.format(january));January>// Prints "January">console.log(spanish.format(january));M01>// Prints "January" on small-icu>// Should print "enero"There was a problem hiding this comment.
FWIW, I use the standalone binary from https://nodejs.org/download/release/latest-v6.x/win-x64/
There was a problem hiding this comment.
Ah you are on Windows. That's different...
There was a problem hiding this comment.
So maybe we can state "January" or "M01"?
vsemozhetbyt
left a comment
There was a problem hiding this comment.
With code output recheck.
PR-URL: nodejs#13916 Refs: nodejs#13644 (comment) Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
TimothyGu
commented
Sep 15, 2017
@vsemozhetbyt Done, PTAL! |
MylesBorins
commented
Sep 19, 2017
landed in 90fcccd |
PR-URL: #13916
Refs: #13644 (comment)
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Checklist
Affected core subsystem(s)
doc