dns, errors: Migrate to use internal/errors by starkwang · Pull Request #14212 · nodejs/node

starkwang · 2017-07-13T01:39:57Z

Migrate dns errors to use internal/errors.

Ref: #11273

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

dns, errors

jasnell · 2017-07-14T20:59:11Z

Perhaps ERR_DNS_SET_SERVERS_FAILED?

jasnell

Very close! thank for doing this. Left a comment I'd like to see addressed.

jasnell

LGTM if CI is green.

XadillaX

LGTM

XadillaX · 2017-07-22T09:07:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9296/

starkwang · 2017-07-22T11:21:05Z

One failure in CI looks unrelated.
https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=0,label=pi1-raspbian-wheezy/9392/console

 ...
not ok 23 parallel/test-child-process-fork-exec-path
---
duration_ms: 8.891
severity: fail
stack: |-
...

refack

Some nits

refack · 2017-07-24T00:33:35Z

new indentation rule requires aligning to the call (
#14403

refack · 2017-07-24T00:34:03Z

refack · 2017-07-24T00:35:13Z

probably better (err, servers) => `c-ares failed to set servers: "${err}" [${servers}]`

refack · 2017-07-24T00:37:04Z

New feature of expectsError can be used without assert.throws:
common.expectsError(dns.resolve('www.google.com',val),{code: 'ERR_INVALID_OPT_VALUE',type: TypeError,message: `The value "${val}" is invalid for option "rrtype"`});

refack · 2017-07-24T00:38:39Z

Used when `c-ares` failed to set the DNS servers.

refack · 2017-07-24T00:41:01Z

@nodejs/ctc @fhinkel @mcollina @mhdawson

starkwang · 2017-07-24T04:33:33Z

Pushed commit to address comments.

mcollina

LGTM

refack · 2017-07-24T11:50:22Z

@starkwang thank you.
CI: https://ci.nodejs.org/job/node-test-pull-request/9319/

refack · 2017-07-24T12:27:45Z

Landed in 9cb390d

PR-URL: #14212 Refs: #11273 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot added dns Issues and PRs related to the dns subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jul 13, 2017

starkwang force-pushed the dns-internal-errors branch from ebfd843 to be61d5dCompare July 13, 2017 06:08

jasnell reviewed Jul 14, 2017
View reviewed changes

Comment threaddoc/api/errors.md Outdated
jasnellJul 14, 2017
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps ERR_DNS_SET_SERVERS_FAILED?

jasnell requested changes Jul 14, 2017
View reviewed changes

starkwang force-pushed the dns-internal-errors branch 2 times, most recently from 1ae02d3 to 56d8131Compare July 18, 2017 07:59

jasnell approved these changes Jul 19, 2017
View reviewed changes

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jul 19, 2017

XadillaX approved these changes Jul 21, 2017
View reviewed changes

refack approved these changes Jul 24, 2017
View reviewed changes

refack reviewed Jul 24, 2017
View reviewed changes

Comment threaddoc/api/errors.md Outdated
refackJul 24, 2017•
edited
Loading
Copy link
Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used when `c-ares` failed to set the DNS servers.

jasnell mentioned this pull request Jul 24, 2017
Tracking Issue: Migrate errors to internal/errors.js #11273
Closed
80 tasks

dns, errors: Migrate to use internal/errors
0653452

starkwang force-pushed the dns-internal-errors branch from 56d8131 to 0653452Compare July 24, 2017 04:31

mcollina approved these changes Jul 24, 2017
View reviewed changes

refack closed this Jul 24, 2017

starkwang mentioned this pull request Jul 27, 2017
http_client, errors: migrate to use internal/errors #14423
Closed
4 tasks

jasnell mentioned this pull request Oct 30, 2017
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135
Merged

Uh oh!

Uh oh!

Conversation

starkwang commented Jul 13, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

jasnellJul 14, 2017

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

XadillaX left a comment

Choose a reason for hiding this comment

Uh oh!

XadillaX commented Jul 22, 2017

Uh oh!

starkwang commented Jul 22, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

refackJul 24, 2017

Choose a reason for hiding this comment

Uh oh!

refackJul 24, 2017

Choose a reason for hiding this comment

Uh oh!

refackJul 24, 2017

Choose a reason for hiding this comment

Uh oh!

refackJul 24, 2017

Choose a reason for hiding this comment

Uh oh!

refackJul 24, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

refack commented Jul 24, 2017

Uh oh!

starkwang commented Jul 24, 2017

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Jul 24, 2017

Uh oh!

refack commented Jul 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

starkwang commented Jul 13, 2017•
edited
Loading

starkwang commented Jul 22, 2017•
edited
Loading

refackJul 24, 2017•
edited
Loading