tools: enable stricter linting in lib directory by Trott · Pull Request #14403 · nodejs/node

Trott · 2017-07-20T20:26:36Z

First commit:

lib: adjust indentation for impending lint change
ESLint 4.x provides stricter indentation linting than previous versions.
In preparation for enabling the stricter indentation linting, adjust the
indentation of four lines in lib/net.js and lib/repl.js.

Second commit:

tools: enable stricter linting in lib directory
Enable ESLint 4.x linting and disable legacy linting in the lib
directory.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

tools lib net repl

Trott · 2017-07-20T20:28:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9276/

evanlucas · 2017-07-20T20:38:13Z

do we not break on all arguments if we break on any? For some reason I thought that was the more used style throughout the codebase

I have not noticed that as the predominant style, although I would welcome that change personally. I'll do that here, if no one objects.

ah, doesn't make much of a difference to me, so up to you. I was mainly just curious. Maybe that was just for cpp code.

Too late, I did it. :-D

mscdex · 2017-07-20T20:50:07Z

Speaking of indentation, shouldn't these be indented a bit further to align with the third argument above it? :-)

Yes. Yes they should. 😐

ESLint 4.x provides stricter indentation linting than previous versions. In preparation for enabling the stricter indentation linting, adjust the indentation of four lines in lib/net.js and lib/repl.js.

Enable ESLint 4.x linting and disable legacy linting in the lib directory. While doing this, some indentation in the .eslintrc.yaml file itself was noticed to be incorrect. Fixed that too.

Trott · 2017-07-23T16:25:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9306/

refack · 2017-07-23T21:40:08Z

~~Just for my info - why just in /lib/?~~ found the others

Trott · 2017-07-24T20:56:40Z

Landed in 8cccdd9 and 7f5a745

ESLint 4.x provides stricter indentation linting than previous versions. In preparation for enabling the stricter indentation linting, adjust the indentation of four lines in lib/net.js and lib/repl.js. PR-URL: #14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

Enable ESLint 4.x linting and disable legacy linting in the lib directory. While doing this, some indentation in the .eslintrc.yaml file itself was noticed to be incorrect. Fixed that too. PR-URL: #14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

addaleax · 2017-07-27T21:31:12Z

Marking as dont-land-on-v8.x because it breaks linting but feel free to backport.

ESLint 4.x provides stricter indentation linting than previous versions. In preparation for enabling the stricter indentation linting, adjust the indentation of four lines in lib/net.js and lib/repl.js. PR-URL: nodejs#14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

Enable ESLint 4.x linting and disable legacy linting in the lib directory. While doing this, some indentation in the .eslintrc.yaml file itself was noticed to be incorrect. Fixed that too. PR-URL: nodejs#14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

Trott · 2017-07-27T21:46:14Z

@addaleax Backported in #14520.

ESLint 4.x provides stricter indentation linting than previous versions. In preparation for enabling the stricter indentation linting, adjust the indentation of four lines in lib/net.js and lib/repl.js. Backport-PR-URL: #14520 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

Enable ESLint 4.x linting and disable legacy linting in the lib directory. While doing this, some indentation in the .eslintrc.yaml file itself was noticed to be incorrect. Fixed that too. Backport-PR-URL: #14520 Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net> PR-URL: #14403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>

nodejs-github-bot added net Issues and PRs related to the net subsystem. repl Issues and PRs related to the REPL subsystem. labels Jul 20, 2017

Trott added tools Issues and PRs related to the tools directory. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 20, 2017

addaleax approved these changes Jul 20, 2017
View reviewed changes

evanlucas reviewed Jul 20, 2017
View reviewed changes

mscdex reviewed Jul 20, 2017
View reviewed changes

lib: adjust indentation for impending lint change
c3b8f5a
ESLint 4.x provides stricter indentation linting than previous versions. In preparation for enabling the stricter indentation linting, adjust the indentation of four lines in lib/net.js and lib/repl.js.

Trott force-pushed the lib-indent branch from 1c4811c to 6f932cdCompare July 20, 2017 21:37

tools: enable stricter linting in lib directory
43fc451
Enable ESLint 4.x linting and disable legacy linting in the lib directory. While doing this, some indentation in the .eslintrc.yaml file itself was noticed to be incorrect. Fixed that too.

Trott force-pushed the lib-indent branch from 6f932cd to 43fc451Compare July 20, 2017 21:38

hiroppy approved these changes Jul 21, 2017
View reviewed changes

cjihrig approved these changes Jul 21, 2017
View reviewed changes

evanlucas approved these changes Jul 21, 2017
View reviewed changes

TimothyGu approved these changes Jul 21, 2017
View reviewed changes

lpinca approved these changes Jul 21, 2017
View reviewed changes

jasnell approved these changes Jul 21, 2017
View reviewed changes

refack approved these changes Jul 23, 2017
View reviewed changes

This was referenced Jul 24, 2017
tools: update to ESLint 4.3.0 #14417
Closed
dns, errors: Migrate to use internal/errors #14212
Closed

aqrln approved these changes Jul 24, 2017
View reviewed changes

Trott closed this Jul 24, 2017

addaleax added dont-land-on-v4.x labels Jul 27, 2017

addaleax added the dont-land-on-v8.x label Jul 27, 2017

Trott mentioned this pull request Jul 27, 2017
[v8.x backport] tools: enable stricter linting in lib directory #14520
Closed
2 tasks

Trott added backported-to-v8.x and removed dont-land-on-v8.x labels Jul 27, 2017

addaleax mentioned this pull request Aug 2, 2017
v8.3.0 proposal #14594
Merged

Trott deleted the lib-indent branch January 13, 2022 22:46

Navigation Menu

Uh oh!

Uh oh!

tools: enable stricter linting in lib directory - #14403

tools: enable stricter linting in lib directory#14403
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:lib-indent

Trott commented Jul 20, 2017

Uh oh!

Trott commented Jul 20, 2017

Uh oh!

evanlucasJul 20, 2017

Uh oh!

TrottJul 20, 2017

Uh oh!

evanlucasJul 20, 2017

Uh oh!

TrottJul 20, 2017

Uh oh!

mscdexJul 20, 2017

Uh oh!

TrottJul 20, 2017

Uh oh!

Trott commented Jul 23, 2017

Uh oh!

refack commented Jul 23, 2017•
edited
Loading

Uh oh!

Trott commented Jul 24, 2017

Uh oh!

addaleax commented Jul 27, 2017

Uh oh!

Trott commented Jul 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Uh oh!

Conversation

Trott commented Jul 20, 2017

Checklist

Affected core subsystem(s)

Uh oh!

Trott commented Jul 20, 2017

Uh oh!

evanlucasJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

TrottJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

evanlucasJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

TrottJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

mscdexJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

TrottJul 20, 2017

Choose a reason for hiding this comment

Uh oh!

Trott commented Jul 23, 2017

Uh oh!

refack commented Jul 23, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Jul 24, 2017

Uh oh!

addaleax commented Jul 27, 2017

Uh oh!

Trott commented Jul 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

refack commented Jul 23, 2017•
edited
Loading