Skip to content

[code & learn]change the typeerror to a regular expression - #14268

Closed
bangwu wants to merge 2 commits into
nodejs:masterfrom
bangwu:fix-stream-writable-null-test
Closed

[code & learn]change the typeerror to a regular expression#14268
bangwu wants to merge 2 commits into
nodejs:masterfrom
bangwu:fix-stream-writable-null-test

Conversation

@bangwu

@bangwubangwu commented Jul 16, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@bangwu
bangwuforce-pushed the fix-stream-writable-null-test branch from 95062b7 to 62dc9f0CompareJuly 16, 2017 07:24
Trott
Trott reviewed Jul 16, 2017
View reviewed changes
Comment threadtest/parallel/test-stream-writable-null.js Outdated
const m = new MyWritable();
m.write(false, (err) => assert.ok(err));
}, TypeError, 'Invalid non-string/buffer chunk');
}, /^TypeError: Invalid non-string\/buffer chunk$/, 'Invalid non-string/buffer chunk');

@TrottTrottJul 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third argument (the string) should probably be removed.

@bangwubangwuJul 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have remove the unused third parameters

@joyeecheungjoyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9148/

@bangwubangwu changed the title [Code & Learn]Change the TypeError to a regular expression[code & learn]change the typeerror to a regular expressionJul 16, 2017
@TimothyGuTimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

Ci looks good. Single failure is unrelated flaky test.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
@bangwu@Trott
test: use regexp to confir error message
242e7a8
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: nodejs#14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

Given straightforward and narrow nature of change, good CI, and plentiful collaborator approval, fast-tracking.

Landed in 242e7a8

@TrottTrott closed this Jul 16, 2017
@Trott

Trott commented Jul 16, 2017

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

@tniessen

tniessen commented Jul 16, 2017

Copy link
Copy Markdown
Member

@Trott There is a typo in your commit message FYI

@TrottTrott marked this as a duplicate of #14294Jul 17, 2017
@TrottTrott mentioned this pull request Jul 17, 2017
Closed
4 tasks
@addaleaxaddaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@bangwu@addaleax
test: use regexp to confir error message
76a4671
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: #14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@bangwu@Fishrock123
test: use regexp to confir error message
1205b12
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: #14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@bangwu@MylesBorins
test: use regexp to confir error message
8a3c113
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: #14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
@bangwu@MylesBorins
test: use regexp to confir error message
49312cb
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: #14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
@bangwu@MylesBorins
test: use regexp to confir error message
b9b343c
In test/parallel/test-stream-writable-null.js, use a regular expression
to validate error message in assert.throws() call.
PR-URL: #14268
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Sep 5, 2017
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+3 more reviewers
@refackrefackrefack approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@bangwu@Trott@tniessen@refack@TimothyGu@cjihrig@gireeshpunathil@gibfahn@MylesBorins@joyeecheung@nodejs-github-bot