Skip to content

[JsConf Code & Learn]change the typeerror to a regular expression - #14294

Closed
bangwu wants to merge 1 commit into
nodejs:masterfrom
bangwu:refactor-stream-writable-null-test
Closed

[JsConf Code & Learn]change the typeerror to a regular expression#14294
bangwu wants to merge 1 commit into
nodejs:masterfrom
bangwu:refactor-stream-writable-null-test

Conversation

@bangwu

@bangwubangwu commented Jul 16, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jul 16, 2017
@bangwubangwu changed the title change the typeerror to a regular expression[JsConf Code & Learn]change the typeerror to a regular expressionJul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
@gibfahn

gibfahn commented Jul 16, 2017

Copy link
Copy Markdown
Member

Commit message needs a bit of fixup. Maybe:

test: change the TypeError to a regular expression

if you're not comfortable amending commits it can be done by whoever lands this.

Thanks for your contribution!

@tniessentniessen self-assigned this Jul 16, 2017
@vsemozhetbyt

vsemozhetbyt commented Jul 16, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9179/

@Trott

Trott commented Jul 17, 2017

Copy link
Copy Markdown
Member

CI is green! 🎉

@Trott

Trott commented Jul 17, 2017

Copy link
Copy Markdown
Member

Duplicate of #14268. Closing.

@TrottTrott marked this as a duplicate of #14268Jul 17, 2017
@TrottTrott closed this Jul 17, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tniessentniessen

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@bangwu@gibfahn@vsemozhetbyt@Trott@benjamingr@TimothyGu@targos@cjihrig@tniessen@gireeshpunathil@nodejs-github-bot