Skip to content

[v8.x] deps: backport V8 update to 6.1 - #15393

Closed
targos wants to merge 13 commits into
nodejs:v8.x-stagingfrom
targos:v8-6.1-v8.x
Closed

[v8.x] deps: backport V8 update to 6.1#15393
targos wants to merge 13 commits into
nodejs:v8.x-stagingfrom
targos:v8-6.1-v8.x

Conversation

@targos

@targostargos commented Sep 13, 2017

Copy link
Copy Markdown
Member

We still need to revert some changes for ABI compatibility.
@addaleax would you like to help me with that? I'm not good enough with C++ to determine which changes could break addons or not.

Output of git diff v8.5.0 deps/v8/include/ > v8-61.diff: https://gist.github.com/targos/d3a1bf91592cb2e9257af94476274f27

/cc @nodejs/v8

Closes: #14220

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-botnodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Sep 13, 2017
@targostargos added wip Issues and PRs that are still a work in progress. semver-minor PRs that contain new features and should be released in the next minor version. labels Sep 13, 2017
@addaleax

addaleax commented Sep 13, 2017

Copy link
Copy Markdown
Member

I’ll take a look and I’m glad to help in whatever way I can, but just so you know, today I heard that @hashseed might already have tried something out?

@addaleax

addaleax commented Sep 13, 2017•
edited
Loading

Copy link
Copy Markdown
Member

From a quick look, the API/ABI breakage is:

  • The removed ForceSet() overload
  • The ArrayBuffer::Contents changes (this one is tricky and we had some prev discussion on this, don’t remember where but I think it was in the previous ABI compat updates)
  • initial_error_prototype being added as a v8::Intrinsic in alphabetical order, not at the end of the list
  • The max_semi_space_size_ field type change
  • AllowCodeGenerationFromStringsCallback now refers to a different kind of function type
  • The AdjustAmountOfExternalAllocatedMemory changes (at least the added CheckMemoryPressure symbol)

Also, some WASM and Modules changes that I think we don’t need to care about…?

@hashseed

hashseed commented Sep 13, 2017

Copy link
Copy Markdown
Member

There was a list of things that Node has to float to make 6.1 ABI compatible with 6.0 somewhere in a node issue by @natorion.

@MylesBorins

MylesBorins commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

@nodejs/tsc if you could chime in on this it would be great

@MylesBorinsMylesBorins mentioned this pull request Sep 13, 2017
Closed
@addaleax

addaleax commented Sep 13, 2017

Copy link
Copy Markdown
Member

@hashseed@natorion was the person who mentioned that you might have worked on sth ;)

I’ll try to work a few things off that list.

@hashseed

hashseed commented Sep 13, 2017

Copy link
Copy Markdown
Member

#14220

I think the ArrayBuffer::Contents class layout issue has already been solved by reordering fields, which already landed in V8 long ago on 6.1. But you better verify :)

@addaleax

addaleax commented Sep 13, 2017

Copy link
Copy Markdown
Member

Right, thanks for looking that up. I mentioned in that thread why just adding the fields at the end isn’t enough, too. ;)

@hashseed

hashseed commented Sep 13, 2017

Copy link
Copy Markdown
Member

Right... In that case it might be better to rip out these fields and essentially revert https://chromium-review.googlesource.com/c/523271/

@addaleax

addaleax commented Sep 13, 2017

Copy link
Copy Markdown
Member

Yeah, possibly more items in that feature set too – I don’t think we really got around to figuring out how to deal with segfaults-that-V8-might-handle

@MylesBorins

MylesBorins commented Sep 14, 2017

Copy link
Copy Markdown
Contributor

/cc @addaleax@bnoordhuis@hashseed do any of you want to own working on ABI compat for this?

@hashseed

hashseed commented Sep 14, 2017

Copy link
Copy Markdown
Member

@psmarshall

@addaleax

addaleax commented Sep 14, 2017

Copy link
Copy Markdown
Member

I pushed an initial set of ABI compat changes to this PR, which should take care of a few items

@SkeLLLaSkeLLLa mentioned this pull request Sep 15, 2017
Closed
@psmarshall

psmarshall commented Sep 15, 2017

Copy link
Copy Markdown
Contributor

@addaleax I had a go at solving the Contents issues.
It lives here: psmarshall@0e14e89

@MylesBorinsMylesBorins mentioned this pull request Sep 15, 2017
Closed
@addaleax

addaleax commented Sep 15, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@psmarshall Thanks, lgtm!
@MylesBorins Included your patch from #15431 in here.

From talking with a few V8 people today, we should probably include/wait for #15431 to land. The changes in there should be low-risk.

CI: https://ci.nodejs.org/job/node-test-commit/12382/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/906/ (edit: at least locally it works … the V8 CI is not exactly in a wonderful state right now)
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/985/

@addaleaxaddaleax mentioned this pull request Sep 15, 2017
Closed
@xymeng2017

xymeng2017 commented Sep 18, 2017

Copy link
Copy Markdown

gogogo! v8 6.2

@vsemozhetbyt

vsemozhetbyt commented Sep 18, 2017

Copy link
Copy Markdown
Contributor

@xymeng2017 It is unlikely: #15362 (comment)

@gibfahn

gibfahn commented Sep 18, 2017

Copy link
Copy Markdown
Member

V8 CI should be working better now (see nodejs/build#886), and #15431 has landed. If there are any more infra issues let me know and I'll take a look.

@addaleax

addaleax commented Sep 18, 2017

Copy link
Copy Markdown
Member

@xymeng2017 I think V8 6.2 on Node 8 is out of the question, sorry.

addaleax
addaleax approved these changes Sep 18, 2017
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good imho, although ofc I can only sign off on the commits that are not from me

(also, to be explicit: +1 to landing V8 6.1 on Node 8)

@addaleaxaddaleax removed the wip Issues and PRs that are still a work in progress. label Sep 18, 2017
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@addaleax@MylesBorins
deps: revert ABI breaking changes in V8 6.1
acd4696
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: #15393
PR-URL: #15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos@MylesBorins
deps: update V8 to 6.1.534.36
d67fb81
PR-URL: #15393
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@mhdawson@MylesBorins
deps: limit regress/regress-crbug-514081 v8 test
21004dd
regress/regress-crbug-514081 allocates a 2G block of memory
and if there are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory. This patch
limits us to running a single variant of the test
Fixes: #6340
Backport-PR-URL: #15393
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bzoz@MylesBorins
deps: fix addons compilation with VS2013
63ebad5
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.
Fixes: nodejs/node-v8#4
Backport-PR-URL: #15393
PR-URL: #13263
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos@MylesBorins
deps: cherry-pick f19b889 from upstream V8
ede9d2e
Original commit message:
[inspector] support for cases when embedder doesn't call contextDestroyed
Node.js doesn't have good place to call contextDestroyed.
We need to cleanup everything on our side to allow clients to not call
contextDestroyed method.
R=dgozman@chromium.org,eostroukhov@chromium.com
Bug: none
Change-Id: Ibe3f01fd18afbfa579e5db66ab6f174d5fad7c82
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/575519
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#46849}
Reviewed-on: https://chromium-review.googlesource.com/596549
Cr-Commit-Position: refs/heads/master@{#47060}
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Matt Loring@MylesBorins
deps: backport 6e9e2e5 from upstream V8
2601a51
Original commit message:
[heap] Move SweeperTask to CancelableTask
This mitigates the problem of blocking on the main thread when the
platform is unable to execute background tasks in a timely manner.
Bug: v8:6655
Change-Id: Icdaae744ee73146b86b9a28c8035138746721971
Reviewed-on: https://chromium-review.googlesource.com/595467
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47036}
Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Matt Loring@MylesBorins
deps: backport bca8409 from upstream V8
19a5021
Original commit message:
Make CancelableTask ids unique
They were only limited to 32 bit when using the internal Hashmap. Since
this has changed alreay some time ago, we can switch to 64 bit ids and
check that we never overflow.
Bug:
Change-Id: Ia6c6d02d6b5e555c6941185a79427dc4aa2a1d62
Reviewed-on: https://chromium-review.googlesource.com/598229
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47085}
Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
Matt Loring@MylesBorins
deps: backport f9c4b7a from upstream V8
d85283b
Original commit message:
[heap] Move UnmapFreeMemoryTask to CancelableTask
This mitigates the problem of blocking on the main thread when the
platform is unable to execute background tasks in a timely manner.
Bug: v8:6671
Change-Id: I741d4b7594e8d62721dad32cbfb19551ffacd0c3
Reviewed-on: https://chromium-review.googlesource.com/599528
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47126}
Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis@MylesBorins
deps: cherry-pick e020aae394 from V8 upstream
273822f
Original commit message:
Work around glibc thread-local storage bug
glibc before 2.17 has a bug that makes it impossible to execute
binaries that have single-byte thread-local variables:
% node --version
node: error while loading shared libraries: cannot allocate
memory in static TLS block
Work around that by making the one instance in the V8 code base
an int.
See: https://sourceware.org/bugzilla/show_bug.cgi?id=14898
See: nodesource/distributions#513
See: nodejs/build#809
Change-Id: Iefd8009100cd93e26cf8dc5dc03f2d622b423385
Reviewed-on: https://chromium-review.googlesource.com/612351
Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47400}
Backport-PR-URL: #15393
PR-URL: #14913
Ref: nodejs/build#809
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@bnoordhuis@MylesBorins
deps: cherry-pick 1aead19 from upstream V8
9934dfe
Original commit message:
Add postmortem metadata for thin strings.
See: nodejs/llnode#117
Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
Reviewed-on: https://chromium-review.googlesource.com/618986
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
Cr-Commit-Position: refs/heads/master@{#47778}
Backport-PR-URL: #15393
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos@MylesBorins
deps: add postmortem metadata for V8 TurboFan
c0b5b09
Refs: nodejs/llnode#130
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/650746
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos@MylesBorins
src: fix SmartOS compilation
2e8652e
Refs: nodejs/node-v8#8
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 3, 2017
@MylesBorins
deps: patch V8 to 6.1.534.38
8471747
Created using the update-v8 npm module and the command
`update-v8 minor`.
Refs: v8/v8@6.1.534.36...6.1.534.38
Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@addaleax@MylesBorins
deps: revert ABI breaking changes in V8 6.1
aa1a3ea
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: #15393
PR-URL: #15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
@MylesBorins
2017-10-11, Node.js Version 8.7.0 (Current)
dc4f1b9
Notable Changes:
* deps:
* update npm to 5.4.2
#15600
* upgrade libuv to 1.15.0
#15745
* update V8 to 6.1.534.42
#15393
* dgram:
* support for setting dgram socket buffer size
#13623
* fs:
* add support O_DSYNC file open constant
#15451
* util:
* deprecate obj.inspect for custom inspection
#15631
* tools, build:
* there is a fancy new macOS installer
#15179
* Added new collaborator
* bmeurer - Benedikt Meurer - https://github.com/bmeurer
* kfarnung - Kyle Farnung - https://github.com/kfarnung
PR-URL: #15762
MylesBorins added a commit that referenced this pull request Oct 11, 2017
@MylesBorins
2017-10-11, Node.js Version 8.7.0 (Current)
b7fec86
Notable Changes:
* deps:
* update npm to 5.4.2
#15600
* upgrade libuv to 1.15.0
#15745
* update V8 to 6.1.534.42
#15393
* dgram:
* support for setting dgram socket buffer size
#13623
* fs:
* add support O_DSYNC file open constant
#15451
* util:
* deprecate obj.inspect for custom inspection
#15631
* tools, build:
* there is a fancy new macOS installer
#15179
* Added new collaborator
* bmeurer - Benedikt Meurer - https://github.com/bmeurer
* kfarnung - Kyle Farnung - https://github.com/kfarnung
PR-URL: #15762
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@MylesBorins@addaleax
2017-10-11, Node.js Version 8.7.0 (Current)
4b1e46b
Notable Changes:
* deps:
* update npm to 5.4.2
nodejs/node#15600
* upgrade libuv to 1.15.0
nodejs/node#15745
* update V8 to 6.1.534.42
nodejs/node#15393
* dgram:
* support for setting dgram socket buffer size
nodejs/node#13623
* fs:
* add support O_DSYNC file open constant
nodejs/node#15451
* util:
* deprecate obj.inspect for custom inspection
nodejs/node#15631
* tools, build:
* there is a fancy new macOS installer
nodejs/node#15179
* Added new collaborator
* bmeurer - Benedikt Meurer - https://github.com/bmeurer
* kfarnung - Kyle Farnung - https://github.com/kfarnung
PR-URL: nodejs/node#15762
@targos
targos deleted the v8-6.1-v8.x branch October 17, 2017 06:30
targos pushed a commit to targos/node that referenced this pull request Jan 15, 2018
@addaleax@targos
deps: revert ABI breaking changes in V8 6.1
a000fbb
Below is the list of changes:
deps: revert 70de12b73c150 from upstream V8
Original commit message:
Remove deprecated ForceSet
Also move the soon-to-be-deprecated version to deprecated
BUG=none
R=ulan@chromium.org
Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
Reviewed-on: https://chromium-review.googlesource.com/518162
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#45554}
[squash] use renamed internal utilities
v8: reorder V8_INTRINSICS_LIST for ABI compat
Make `kErrorPrototype` added at the end of the `Intrinsic` for
ABI compatibility.
deps: revert 0089c786ed882 from V8 upstream
Original commit message:
Merged: Squashed multiple commits.
Merged: [heap] Add API to set heap semi-space limits in KB.
Revision: bb29f9a4d6fb5e32
Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
Revision: 7486dc3331
Merged: [heap] Set initial semi-space size to 512K.
Revision: a5230d81d1f73c
BUG=chromium:716032,chromium:735649
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
Reviewed-on: https://chromium-review.googlesource.com/616283
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{nodejs#47}
Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{nodejs#46746}
v8: work around callback typedef renaming
Do some clever tricks to have an easy way around
V8 renaming one of its typedef to a deprecated version and then
introducing a new typedef with the same name.
deps: revert 5ebd6fcd269de from V8 upstream
Original commit message:
[heap] Lower external allocation limit when external memory shrinks.
BUG=chromium:728228
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2921883002
Cr-Commit-Position: refs/heads/master@{nodejs#45726}
deps: revert cf8f7bdc9d5ee from V8 upstream
Original commit message:
[heap] Increase memory reducer activation limit for external memory changes.
BUG=chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2923563006
Cr-Commit-Position: refs/heads/master@{nodejs#45763}
deps: revert 11fc9fab94d48 from V8 upstream
Original commit message:
[heap] Guard against re-entering GC on external memory change.
TBR=hpayer@chromium.org
BUG=chromium:729868,chromium:729521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2929463002
Cr-Commit-Position: refs/heads/master@{nodejs#45745}
deps: revert 502c6ae6a0397 from V8 upstream
Original commit message:
[heap] Activate memory reducer on external memory activity.
BUG=chromium:728228,chromium:626082
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng
Review-Url: https://codereview.chromium.org/2917853004
Cr-Commit-Position: refs/heads/master@{nodejs#45671}
v8: revert changes to Contents structs
The feature is disabled by default anyway,but we disable it completely.
Backport-PR-URL: nodejs#15393
PR-URL: nodejs#15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@zbjornsonzbjornson mentioned this pull request Oct 21, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@evanlucasevanlucasevanlucas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver-minorPRs that contain new features and should be released in the next minor version.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

17 participants

@targos@addaleax@hashseed@MylesBorins@psmarshall@xymeng2017@vsemozhetbyt@gibfahn@jasnell@ofrobots@mcollina@fhinkel@evanlucas@nodejs-github-bot@mhdawson@bzoz@bnoordhuis