Uh oh!
There was an error while loading. Please reload this page.
test: replace string concatenation with template literals - #15924
Closed
jphblais wants to merge 3 commits into
Closed
test: replace string concatenation with template literals#15924jphblais wants to merge 3 commits into
jphblais wants to merge 3 commits into
Conversation
vsemozhetbyt
approved these changes
Oct 6, 2017
4 tasks
cjihrig
reviewed
Oct 7, 2017
| const moduleMap = new ModuleMap(); | ||
| assert.throws(() => moduleMap.get({}), errorReg); |
Contributor
There was a problem hiding this comment.
You could DRY this file up a bit if you did something like:
[{},[],true,1,()=>{}].forEach((value)=>{assert.throws(()=>moduleMap.get(value),errorReg);});Contributor
Welcome @jphblais and thank you for the contribution 🥇 Quick CI: |
tniessen
reviewed
Oct 7, 2017
| assert.throws(() => moduleMap.has(1), errorReg); | ||
| assert.throws(() => moduleMap.has(() => {}), errorReg); |
Member
There was a problem hiding this comment.
Non-blocking nit: I would love it if your assertions were not separated by empty lines as long as they do not use more than a single line themselves.
BridgeAR
commented
Oct 9, 2017
Member
@jphblais would you also be so kind and remove the merge commit by rebasing and force pushing the branch? |
lance
commented
Oct 9, 2017
Member
BridgeAR
approved these changes
Oct 18, 2017
BridgeAR pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit
that referenced
this pull request
Oct 19, 2017
PR-URL: #15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
Oct 19, 2017
Member
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
Oct 23, 2017
PR-URL: #15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#15924 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test