Uh oh!
There was an error while loading. Please reload this page.
test: improve coverage of lib/internal/loader/ModuleMap.js - #16061
Closed
jphblais wants to merge 1 commit into
Closed
test: improve coverage of lib/internal/loader/ModuleMap.js#16061jphblais wants to merge 1 commit into
jphblais wants to merge 1 commit into
Conversation
Contributor
@jphblais, hi. Thank you for contributions! It may be better to use new branches for different PRs, so that their commits are not duplicated and mixed. |
bmeck
approved these changes
Oct 7, 2017
bmeck
left a comment
Member
There was a problem hiding this comment.
LGTM, nit on comment is not blocking.
| // As long as the assertion of "job" argument is done after the assertion of | ||
| // "url" argument this test suite is ok. Tried to mock the "job" parameter, | ||
| // but I think it's useless, and was not simple to mock... |
Member
There was a problem hiding this comment.
Can we remove the extra text, I think the first sentence is enough:
Tried to mock the "job" parameter, but I think it's useless, and was not simple to mock...
addaleax
approved these changes
Oct 7, 2017
tniessen
reviewed
Oct 7, 2017
| assert.throws(() => moduleMap.has(1), errorReg); | ||
| assert.throws(() => moduleMap.has(() => {}), errorReg); |
Member
There was a problem hiding this comment.
Nit: We don't really need to keep all of the assertions separated by empty lines, and we usually don't do it for single-line assertions. I think it mostly blows up the visual file size in this case.
TimothyGu
approved these changes
Oct 7, 2017
BridgeAR
commented
Oct 9, 2017
Member
Member
CI has some failures that appear to be unrelated. smartos15-64smartos16-640,pi3-raspbian-jessieI will self-assign and land this unless there are objections based on these test results. |
2 tasks
lpinca
approved these changes
Oct 14, 2017
| const moduleMap = new ModuleMap(); | ||
| assert.throws(() => moduleMap.get({}), errorReg); |
Member
There was a problem hiding this comment.
Nit: we can put these in a loop to adhere to the DRY principle:
[{},[],true,1,()=>{}].forEach((element)=>{assert.throws(()=>moduleMap.get(element),errorReg);});Member
There was a problem hiding this comment.
These should likely be made into...
common.expectsError(()=>moduleMap.get([]),{code: 'ERR_INVALID_ARG_TYPE',type: TypeError,message: /^The"url"argumentmustbeoftypestring/});etc
hiroppy
approved these changes
Oct 17, 2017
tniessen
commented
Oct 20, 2017
Member
Seems like this needs to be rebased. |
Trott
commented
Oct 27, 2017
Member
Obsoleted by #15924 from same author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to cover the exceptions "throw'ed" in ModuleMap class.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)