Uh oh!
There was an error while loading. Please reload this page.
js_stream: fix buffer index in DoWrite - #1635
Closed
shigeki wants to merge 1 commit into
Closed
Conversation
The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by Brian White in nodejs#1594. Fixes: nodejs#1595Fixes: nodejs#1594
indutny
commented
May 6, 2015
Member
LGTM, thank you! |
indutny
commented
May 6, 2015
Member
This was referenced May 6, 2015
Fishrock123 pushed a commit
to Fishrock123/node
that referenced
this pull request
May 19, 2015
The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by Brian White in nodejs#1594. Fix: nodejs#1595Fix: nodejs#1594 PR-URL: nodejs#1635 Reviewed-By: Fedor Indutny <fedor@indutny.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index of buffer to write in JSStream was always 0 by mistake. This fix was to use increment index of buffer arrays. The test was originally made by @mscdex in #1594.
CI results are https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/646/ . Most of failures are caused by cpplint errors.
Fixes: #1595
Fixes: #1594
R= @indutny