Skip to content

doc: improve specificity in CODEOWNERS - #20729

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-codeowners
Closed

doc: improve specificity in CODEOWNERS#20729
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-codeowners

Conversation

@Trott

@TrottTrott commented May 14, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.

Ref: #20717 (comment)

@richardlau

Checklist

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 14, 2018
@vsemozhetbyt

vsemozhetbyt commented May 14, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott

Trott commented May 14, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/707/

@TrottTrott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 14, 2018
@vsemozhetbyt

vsemozhetbyt commented May 15, 2018

Copy link
Copy Markdown
Contributor

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@Trott

Trott commented May 15, 2018

Copy link
Copy Markdown
MemberAuthor

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

@Trott

Trott commented May 15, 2018

Copy link
Copy Markdown
MemberAuthor

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

It also means we may want to reduce the number of entries in CODEOWNERS.

@targos

targos commented May 15, 2018

Copy link
Copy Markdown
Member

It is interesting why @nodejs/documentation, @nodejs/repl, and @nodejs/testing are not tagged automatically there.

@vsemozhetbyt The last entry that matches has precedence and is the only one used. We probably want to re-order our CODEOWNERS file carefully.

That's true but I don't think this PR will fix it alone. According to the documentation, those teams cannot be cc'd for review because they do not have write access to the repository.

@apapirovski

apapirovski commented May 16, 2018

Copy link
Copy Markdown
Contributor

@Trott same here, also needs a rebase before landing.

@Trott
doc: improve specificity in CODEOWNERS
3de0a5f
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.
@Trott

Trott commented May 16, 2018

Copy link
Copy Markdown
MemberAuthor

@apapirovski Rebased.

@Trott

Trott commented May 16, 2018

Copy link
Copy Markdown
MemberAuthor

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/716/

@Trott

Trott commented May 16, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 67463ad

@TrottTrott closed this May 16, 2018
Trott added a commit to Trott/io.js that referenced this pull request May 16, 2018
@Trott
doc: improve specificity in CODEOWNERS
67463ad
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.
PR-URL: nodejs#20729
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@Trott@MylesBorins
doc: improve specificity in CODEOWNERS
7943449
Update CODEOWNERS entry for README.md to only apply to the top level
README.md. For example, if test/common/README.md is updated, that should
not be assigned to TSC automatically.
PR-URL: #20729
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request May 22, 2018
Merged
@Trott
Trott deleted the fix-codeowners branch January 13, 2022 22:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes
+5 more reviewers
@danbevdanbevdanbev approved these changes
@maclover7maclover7maclover7 approved these changes
@hiroppyhiroppyhiroppy approved these changes
@devsnekdevsnekdevsnek approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@Trott@vsemozhetbyt@targos@apapirovski@danbev@jasnell@maclover7@hiroppy@devsnek@BridgeAR@trivikr@nodejs-github-bot