errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK by ChALkeR · Pull Request #21493 · nodejs/node

ChALkeR · 2018-06-23T23:35:04Z

This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the INTST vs INST) in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused.

This error code never worked or was documented under the mistyped name
ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to
ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix.

Refs: #21440, #21470, #16874, #18857.

This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format.

This is mostly a revert, and specific tests for esm loader actually emitting that error are not included here.
Generic tests for error codes are included in a separate PR: #21470.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-06-23T23:35:05Z

@ChALkeR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/137/pipeline

devsnek

sorry about that 😃

on a side note, how come our eslint rules didn't pick up throwing a non-internal-error

ChALkeR · 2018-06-23T23:55:51Z

@devsnek eslint doesn't track that. #21470 does 😉 — that's what picked that up.

jasnell · 2018-06-29T18:29:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15668/

targos · 2018-06-30T09:08:34Z

Ping @ChALkeR there is a small conflict.

ChALkeR · 2018-06-30T09:16:08Z

@targos, sorry, I am not feeling well and have only my phone right now. 🌡️
I will be able to take a look at this later (I suppose today-tomorrow).
Alternatively, I would be happy if anyone could take it from this point.

targos · 2018-06-30T09:17:55Z

@ChALkeR sure. I hope you get better soon! I'm happy to take it over. Can I push to your branch?

ChALkeR · 2018-06-30T09:22:51Z

@targos, thanks!
Yes, of course - I think that left the appropriate flag checked.

targos · 2018-06-30T09:28:10Z

Rebased.
CI: https://ci.nodejs.org/job/node-test-pull-request/15680/

This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR nodejs#16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR nodejs#18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: nodejs#21440 Refs: nodejs#21470 Refs: nodejs#16874 Refs: nodejs#18857

targos · 2018-06-30T12:58:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/15685/
Edit: resumed Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19056/

ChALkeR · 2018-06-30T20:10:47Z

@targos Thanks for that again!

targos · 2018-06-30T21:02:47Z

No problem!
And trying Windows again... https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/19059/

targos · 2018-06-30T21:49:23Z

Landed in 7bdc694

This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: #21440 Refs: #21470 Refs: #16874 Refs: #18857 PR-URL: #21493 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ChALkeR · 2018-06-30T22:10:33Z

Node.js v10.x is affected.
v8.x — only after #16874 is backported (if it gets backported).

This restores a broken and erroneously removed error, which was accidentially renamed to ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK (notice the "INTST" vs "INST") in 921fb84 (PR #16874) and then had documentation and implementation removed under the old name in 6e1c25c (PR #18857), as it appeared unused. This error code never worked or was documented under the mistyped name ERR_MISSING_DYNAMIC_INTSTANTIATE_HOOK, so renaming it back to ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK is a semver-patch fix. Refs: #21440 Refs: #21470 Refs: #16874 Refs: #18857 PR-URL: #21493 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ChALkeR added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 23, 2018

nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 23, 2018

ChALkeR force-pushed the doc-errcodes-remove-unused2 branch from bd6bb89 to 1a1b056Compare June 23, 2018 23:39

ChALkeR mentioned this pull request Jun 23, 2018
errors: fix ERR_MISSING_DYNAMIC_INSTANTIATE_HOOK #21492
Closed
4 tasks

ChALkeR force-pushed the doc-errcodes-remove-unused2 branch 2 times, most recently from bbcb61d to 1fcf5e1Compare June 23, 2018 23:48

ChALkeR added the esm Issues and PRs related to the ECMAScript Modules implementation. label Jun 23, 2018

ChALkeR requested review from BridgeAR, bmeck, devsnek, ronkorving and vsemozhetbyt June 23, 2018 23:52

devsnek approved these changes Jun 23, 2018
View reviewed changes

ChALkeR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 23, 2018

This was referenced Jun 24, 2018
test: add test for error codes doc and impl #21470
Closed
ERR_TLS_RENEGOTIATE, ERR_HTTP2_SETTINGS_CANCEL are not defined #21440
Closed

trivikr approved these changes Jun 24, 2018
View reviewed changes

vsemozhetbyt approved these changes Jun 24, 2018
View reviewed changes

targos mentioned this pull request Jun 24, 2018
test: add test for missing dynamic instantiate hook #21506
Closed
3 tasks

TimothyGu approved these changes Jun 24, 2018
View reviewed changes

benjamingr approved these changes Jun 24, 2018
View reviewed changes

jasnell approved these changes Jun 24, 2018
View reviewed changes

ronkorving approved these changes Jun 25, 2018
View reviewed changes

lpinca approved these changes Jun 25, 2018
View reviewed changes

targos force-pushed the doc-errcodes-remove-unused2 branch from 1fcf5e1 to d7fa6c2Compare June 30, 2018 09:27

targos force-pushed the doc-errcodes-remove-unused2 branch from d7fa6c2 to 75bf6a8Compare June 30, 2018 12:58

ChALkeR mentioned this pull request Jun 30, 2018
loader: refactor loader #16874
Closed
3 tasks

targos closed this Jun 30, 2018

targos mentioned this pull request Jul 3, 2018
v10.6.0 proposal #21629
Merged

Uh oh!

Uh oh!

Conversation

ChALkeR commented Jun 23, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Jun 23, 2018

Uh oh!

devsnek left a comment

Choose a reason for hiding this comment

Uh oh!

ChALkeR commented Jun 23, 2018

Uh oh!

jasnell commented Jun 29, 2018

Uh oh!

targos commented Jun 30, 2018

Uh oh!

ChALkeR commented Jun 30, 2018

Uh oh!

targos commented Jun 30, 2018

Uh oh!

ChALkeR commented Jun 30, 2018

Uh oh!

targos commented Jun 30, 2018

Uh oh!

targos commented Jun 30, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChALkeR commented Jun 30, 2018

Uh oh!

targos commented Jun 30, 2018

Uh oh!

targos commented Jun 30, 2018

Uh oh!

ChALkeR commented Jun 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ChALkeR commented Jun 23, 2018•
edited
Loading

targos commented Jun 30, 2018•
edited
Loading