Uh oh!
There was an error while loading. Please reload this page.
test: add test for missing dynamic instantiate hook - #21506
Closed
targos wants to merge 1 commit into
Closed
Conversation
benjamingr
approved these changes
Jun 24, 2018
benjamingr
left a comment
Member
There was a problem hiding this comment.
LGTM given the other two land
jasnell
approved these changes
Jun 24, 2018
targosforce-pushed
the
test-add-esm-missing-dyn
branch
from
June 30, 2018 21:57
6116551 to
543142fCompareMemberAuthor
devsnek
approved these changes
Jun 30, 2018
targos
commented
Jul 3, 2018
MemberAuthor
Landed in 908518d |
targos added a commit
that referenced
this pull request
Jul 3, 2018
PR-URL: #21506 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
targos added a commit
that referenced
this pull request
Jul 4, 2018
PR-URL: #21506 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on:
#21352
#21493
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes