Skip to content

errors: fix undefined HTTP2 and tls errors - #21564

Closed
thatshailesh wants to merge 1 commit into
nodejs:masterfrom
thatshailesh:fix-undefined-errors
Closed

errors: fix undefined HTTP2 and tls errors#21564
thatshailesh wants to merge 1 commit into
nodejs:masterfrom
thatshailesh:fix-undefined-errors

Conversation

@thatshailesh

@thatshaileshthatshailesh commented Jun 27, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Includes implementation of tls, HTTP2 error with documentation
Ref: #21440

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@thatshailesh
errors: fix undefined HTTP2 and tls errors
824b224
Includes implementation of tls, HTTP2 error with documentation
@nodejs-github-botnodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Jun 27, 2018
vsemozhetbyt
vsemozhetbyt reviewed Jun 27, 2018
View reviewed changes
Comment threaddoc/api/errors.md
<a id="ERR_TLS_RENEGOTIATE"></a>
### ERR_TLS_RENEGOTIATE

An attempt was made to renegotiate TLS session failed.

@vsemozhetbytvsemozhetbytJun 27, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this wording a bit off? Maybe An attempt made to renegotiate... or even An attempt to renegotiate...?

@thatshaileshthatshaileshJun 28, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure, thats why I asked everyone here #21440 about the message

@jasnelljasnellJun 29, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An attempt to renegotiate the TLS session failed.

@vsemozhetbytvsemozhetbyt added tls Issues and PRs related to the tls subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jun 27, 2018
@vsemozhetbytvsemozhetbyt mentioned this pull request Jun 28, 2018
Closed
3 tasks
@ChALkeR

ChALkeR commented Jun 29, 2018

Copy link
Copy Markdown
Member

/cc @jasnell@mcollina@mhdawson

@ChALkeR
ChALkeR requested a review from jasnellJune 29, 2018 19:06
@vsemozhetbyt

vsemozhetbyt commented Jul 9, 2018

Copy link
Copy Markdown
Contributor

ping @nodejs/http2

mcollina
mcollina approved these changes Jul 10, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina

mcollina commented Jul 10, 2018

Copy link
Copy Markdown
Member

@vsemozhetbyt@jasnell are you now ok for this to land?

@jasnell

jasnell commented Jul 10, 2018 via email

Copy link
Copy Markdown
Member

@vsemozhetbyt

vsemozhetbyt commented Jul 10, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

If @jasnell's wording will be added while landing, I am OK)

@mcollina

mcollina commented Jul 10, 2018•
edited
Loading

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/243/
CI: https://ci.nodejs.org/job/node-test-pull-request/15783/

apapirovski
apapirovski approved these changes Jul 10, 2018
View reviewed changes

@apapirovskiapapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the wording from @jasnell

@vsemozhetbyt

vsemozhetbyt commented Jul 12, 2018

Copy link
Copy Markdown
Contributor

Let's land this tomorrow with the wording from @jasnell if there are no amendments by that time.

vsemozhetbyt pushed a commit that referenced this pull request Jul 13, 2018
@thatshailesh@vsemozhetbyt
errors: fix undefined HTTP2 and tls errors
3950a3e
Includes implementation of tls, HTTP2 error with documentation.
PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@vsemozhetbyt

vsemozhetbyt commented Jul 13, 2018

Copy link
Copy Markdown
Contributor

Landed in 3950a3e
Thank you!

targos pushed a commit that referenced this pull request Jul 14, 2018
@thatshailesh@targos
errors: fix undefined HTTP2 and tls errors
3fffc7e
Includes implementation of tls, HTTP2 error with documentation.
PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targostargos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@ChALkeRChALkeR mentioned this pull request Jul 23, 2018
Closed
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@thatshailesh@kjin
errors: fix undefined HTTP2 and tls errors
7b721eb
Includes implementation of tls, HTTP2 error with documentation.
PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@thatshailesh@kjin
errors: fix undefined HTTP2 and tls errors
28feb05
Includes implementation of tls, HTTP2 error with documentation.
PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@thatshailesh@kjin
errors: fix undefined HTTP2 and tls errors
a9053fa
Includes implementation of tls, HTTP2 error with documentation.
PR-URL: nodejs#21564
Refs: nodejs#21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@thatshailesh@BethGriggs
errors: fix undefined HTTP2 and tls errors
57618aa
Includes implementation of tls, HTTP2 error with documentation.
Backport-PR-URL: #22850
PR-URL: #21564
Refs: #21440
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BethGriggsBethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelopbeevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnellAwaiting requested review from jasnell
+2 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.http2Issues or PRs related to the http2 subsystem.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thatshailesh@ChALkeR@vsemozhetbyt@mcollina@jasnell@apapirovski@nodejs-github-bot