Uh oh!
There was an error while loading. Please reload this page.
doc: fix typo in fs.md - #21579
Conversation
Fixes simple typo of `excludiing` to `excluding`.
vsemozhetbyt
commented
Jun 28, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Trott
commented
Jun 28, 2018
vsemozhetbyt
commented
Jun 28, 2018
@Trott BTW, should we run an explicit CI-lite in such cases since the CI-lite is launched automatically now as Travis CI? |
Trott
commented
Jun 28, 2018
CI Lite is only launched for PRs opened by Collaborators. It was not automatically launched on this PR, for example. We could choose to decide that the Travis CI is a sufficient equivalent to Lite CI but I would not want to make that call unilaterally. :-D |
vsemozhetbyt
commented
Jun 28, 2018
But it did launch on this PR, I've seen this result before your launch: https://github.com/nodejs/node/pull/21579/checks?check_run_id=5686153 Maybe it is launched for doc only PRs whoever makes them? |
See for example #21564: CI-lite is performed in https://github.com/nodejs/node/pull/21564/checks Oops, and that PR is not doc-only... Is this a security breach? |
Trott
commented
Jun 28, 2018
@vsemozhetbyt Both of those links are to Travis CI runs. Those run automatically on all PRs. That's fine. The Jenkins ci.nodejs.org node-test-pull-request-lite jobs are the ones that only run automatically for PRs opened by Collaborators. |
vsemozhetbyt
commented
Jun 28, 2018
What is the difference? Since Travis CI seems to contain the same linux-one and linter job. |
Trott
commented
Jun 28, 2018
Travis CI is sandboxed, so it's OK to run automatically for everyone. However, it makes available only a fraction of the platforms that we test on ourselves and that we care about. So (at this time anyway) it can only replace or duplicate a few functions of our own CI. |
Fixes simple typo of `excludiing` to `excluding`. PR-URL: #21579 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
vsemozhetbyt
commented
Jun 28, 2018
Landed in d6397af |
Fixes simple typo of `excludiing` to `excluding`. PR-URL: #21579 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Fixes simple typo of
excludiingtoexcluding.make -j4 test(UNIX) passes