Uh oh!
There was an error while loading. Please reload this page.
test: fix timeouts when running worker tests with --worker - #21791
Closed
addaleax wants to merge 1 commit into
Closed
test: fix timeouts when running worker tests with --worker#21791addaleax wants to merge 1 commit into
--worker#21791addaleax wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
These tests have been added after the original workers PR and time out when run inside a worker by themselves. This is needed for enabling `--worker` tests in our regular CI. Refs: nodejs/build#1318
addaleaxforce-pushed
the
worker-test-timeout
branch
from
July 13, 2018 13:11
6b84655 to
0a8a6d2Compareaddaleax
commented
Jul 13, 2018
MemberAuthor
Full CI: https://ci.nodejs.org/job/node-test-pull-request/15846/ Please 👍 this comment if you approve of fast-tracking this PR. |
maclover7
commented
Jul 13, 2018
Contributor
Worker-tests-CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/91/ |
3 tasks
maclover7
approved these changes
Jul 13, 2018
addaleax
commented
Jul 13, 2018
MemberAuthor
refack
approved these changes
Jul 13, 2018
addaleax
commented
Jul 13, 2018
MemberAuthor
Landed in 36cc5f5 |
addaleax added a commit
that referenced
this pull request
Jul 13, 2018
These tests have been added after the original workers PR and time out when run inside a worker by themselves. This is needed for enabling `--worker` tests in our regular CI. Refs: nodejs/build#1318 PR-URL: #21791 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 14, 2018
These tests have been added after the original workers PR and time out when run inside a worker by themselves. This is needed for enabling `--worker` tests in our regular CI. Refs: nodejs/build#1318 PR-URL: #21791 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests have been added after the original workers PR and
time out when run inside a worker by themselves.
This is needed for enabling
--workertests in our regular CI.Refs: nodejs/build#1318
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes