Uh oh!
There was an error while loading. Please reload this page.
test: fix weird string error - #21793
Closed
maclover7 wants to merge 1 commit into
Closed
Conversation
Previously getting this error when running `tap2junit` (what parses our `.tap` files in CI): ``` Traceback (most recent call last): File "/usr/local/bin/tap2junit", line 11, in <module> sys.exit(main()) File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main result.to_file(args.output, [result], prettyprint=False) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file test_suites, prettyprint=prettyprint, encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string ts_xml = ts.build_xml_doc(encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc attrs['message'] = decode(case.skipped_message, encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode ret = unicode(var) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128) ```
maclover7
commented
Jul 13, 2018
ContributorAuthor
This, with #21791, will make |
addaleax
approved these changes
Jul 13, 2018
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM as a workaround, but please let’s also fix this upstream :/
ContributorAuthor
Full CI: https://ci.nodejs.org/job/node-test-pull-request/15852/ Edit by @addaleax: CI came back green, please 👍 to approve fast-tracking |
lpinca
approved these changes
Jul 13, 2018
addaleax
commented
Jul 13, 2018
Member
Landed in 2d95070, thanks! |
addaleax pushed a commit
that referenced
this pull request
Jul 13, 2018
Previously getting this error when running `tap2junit` (what parses our `.tap` files in CI): ``` Traceback (most recent call last): File "/usr/local/bin/tap2junit", line 11, in <module> sys.exit(main()) File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main result.to_file(args.output, [result], prettyprint=False) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file test_suites, prettyprint=prettyprint, encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string ts_xml = ts.build_xml_doc(encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc attrs['message'] = decode(case.skipped_message, encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode ret = unicode(var) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128) ``` PR-URL: #21793 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Jul 14, 2018
Previously getting this error when running `tap2junit` (what parses our `.tap` files in CI): ``` Traceback (most recent call last): File "/usr/local/bin/tap2junit", line 11, in <module> sys.exit(main()) File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 46, in main result.to_file(args.output, [result], prettyprint=False) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 289, in to_file test_suites, prettyprint=prettyprint, encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 257, in to_xml_string ts_xml = ts.build_xml_doc(encoding=encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 221, in build_xml_doc attrs['message'] = decode(case.skipped_message, encoding) File "/usr/local/lib/python2.7/site-packages/junit_xml/__init__.py", line 68, in decode ret = unicode(var) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 11: ordinal not in range(128) ``` PR-URL: #21793 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously getting this error when running
tap2junit(what parses our.tapfiles in CI):Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes