Uh oh!
There was an error while loading. Please reload this page.
http2: remove streamError from docs - #22246
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: nodejs#20211
jasnell
commented
Aug 10, 2018
MemberAuthor
lpinca
approved these changes
Aug 10, 2018
maclover7
approved these changes
Aug 10, 2018
cjihrig
approved these changes
Aug 10, 2018
jasnell
commented
Aug 11, 2018
MemberAuthor
Please 👍 to fast track |
| // Check that destroying the Http2ServerResponse stream produces | ||
| // the expected result, including the ability to throw an error | ||
| // which is emitted on server.streamError | ||
| // the expected result |
Contributor
There was a problem hiding this comment.
Nit: period at the comment end?
vsemozhetbyt
approved these changes
Aug 11, 2018
trivikr
approved these changes
Aug 12, 2018
jasnell
commented
Aug 12, 2018
MemberAuthor
jasnell added a commit
that referenced
this pull request
Aug 12, 2018
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: #20211 PR-URL: #22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
commented
Aug 12, 2018
MemberAuthor
Landed in c8aa83c (fast-tracked with approval) |
targos pushed a commit
that referenced
this pull request
Aug 12, 2018
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: #20211 PR-URL: #22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
kjin pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: nodejs#20211 PR-URL: nodejs#22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: nodejs#20211 PR-URL: nodejs#22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Oct 17, 2018
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: #20211 Backport-PR-URL: #22850 PR-URL: #22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
firass111 pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
`streamError` was removed quite some time ago but the docs and code comments weren't updated. Fix that. Fixes: nodejs/node#20211 PR-URL: nodejs/node#22246 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streamErrorwas removed quite some time ago but the docs andcode comments weren't updated. Fix that.
Fixes: #20211
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes