Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick dbfcc48 from upstream V8 - #22251
Conversation
alexkozy
commented
Aug 10, 2018
By accident I broke my previous PR: #22224 |
Trott
commented
Aug 11, 2018
@nodejs/v8 |
TimothyGu
commented
Aug 16, 2018
This LGTM by itself, but I'd prefer landing this with the actual Node.js |
alexkozy
commented
Aug 21, 2018
@TimothyGu please take another look. |
alexkozy
commented
Aug 29, 2018
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexkozy
commented
Aug 30, 2018
@TimothyGu I addressed your comments and added one more test. Please take another look. |
TimothyGu
left a comment
There was a problem hiding this comment.
Newly added code LGTM. Some logistical comments.
There was a problem hiding this comment.
I'm a bit reluctant to touch into the internals in this way. Could something like this work?
URLurl("file:///");This will also need a cctest (see https://github.com/nodejs/node/blob/master/test/cctest/test_url.cc).
Finally could you split the changes to node_url into a separate commit?
alexkozy
commented
Aug 30, 2018
Addressed comments and started another CI: https://ci.nodejs.org/job/node-test-pull-request/16880/ |
TimothyGu
left a comment
There was a problem hiding this comment.
Hmm, jumped the gun there. Left a few more comments.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexkozy
commented
Sep 4, 2018
Failure on Windows bot looks unrelated. @TimothyGu could you take another look? |
BridgeAR
commented
Sep 5, 2018
This needs a rebase. |
BridgeAR
commented
Sep 5, 2018
@nodejs/v8-update PTAL. This needs some LGs |
alexkozy
commented
Sep 11, 2018
Rebased and started CI: https://ci.nodejs.org/job/node-test-pull-request/17120/ |
alexkozy
commented
Sep 12, 2018
rebased and restarted CI again since I believe that failure is unrelated: https://ci.nodejs.org/job/node-test-pull-request/17126/ |
alexkozy
commented
Sep 12, 2018
alexkozy
commented
Sep 13, 2018
Windows bot looks disabled on CI, based on previous CI all related tests passed, I am not sure, should I wait until windows is fixed on CI or can I land it as is? |
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
Wired up support for calling the node-provided `resourceNameToUrl` method in the chakrashim inspector. This reverts commit 3f6ef13. PR-URL: nodejs#601Fixes: nodejs#598 Refs: nodejs/node#22251 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Seth Brenith <sethb@microsoft.com>
Original commit message: ``` [inspector] added V8InspectorClient::resourceNameToUrl Some clients (see Node.js) use platform path as ScriptOrigin. Reporting platform path in protocol makes using protocol much harder. This CL introduced V8InspectorClient::resourceNameToUrl method that is called for any reported using protocol url. V8Inspector uses url internally as well so protocol client may generate pattern for blackboxing with file urls only and does not need to build complicated regexp that covers files urls and platform paths on different platforms. R=lushnikov@chromium.org TBR=yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff302e7441df922fa5d689fe510f5a9bfd470b9b Reviewed-on: https://chromium-review.googlesource.com/1164624 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#55029} ``` Refs: v8/v8@dbfcc48 Backport-PR-URL: #22918 PR-URL: #22251 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Original commit message:
Refs: v8/v8@dbfcc48
Needed for #22223
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes