fs: make process.binding('fs') internal by shisama · Pull Request #22478 · nodejs/node

shisama · 2018-08-23T14:32:55Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

addaleax · 2018-08-23T14:35:44Z

I’d prefer not to rush this one, given the history we have with fs bindings… Can we maybe land it early after the Node 11 semver-major cut?

addaleax · 2018-08-23T14:36:45Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1519/

jasnell · 2018-08-23T14:46:50Z

This one also needs to be added to the fall-through whitelist in internal/bootstrap/node.js

jdalton · 2018-08-23T23:43:40Z

@shisama For reference of the allow list changes you can check out this other pr.

shisama · 2018-08-25T03:08:06Z

Thank you for your reviews. I fixed them.

BridgeAR

LGTM for version 12.

jdalton · 2018-09-04T15:02:30Z

Why the semver-major on this if it's just changing how internally the fs binding is referenced? Externally process.binding('fs') still works the same, right?

jasnell · 2018-09-04T15:05:40Z

That's just being very defensive and careful. process.binding() can be... touchy.

targos · 2018-09-04T18:05:33Z

Semver-major makes sense but do we really need to prevent this from being in Node 11? I mean, we do not expect this to break anything and if citgm is fine with it and npm or graceful-fs are not broken, I think it's fine.

jasnell · 2018-09-04T18:19:50Z

If citgm (and npm in particular) will continue to work, then I'm +1 on landing this in 11.

jasnell · 2018-09-04T18:20:42Z

I don't believe this should be labeled blocked. If there's a disagreement on whether it should land for 11, then let's flag it for tsc-review or tsc-agenda.

This is failing in CI

jasnell

There are relevant CITGM failures that need to be investigated.

BridgeAR · 2018-09-05T14:05:21Z

CI https://ci.nodejs.org/job/node-test-pull-request/17032/ (The failure looked like it should also show up in our tests).

shisama · 2018-10-18T01:04:43Z

@jasnell @BridgeAR Thank you for your review and running CI. I rebased this, please run CI again. Thanks.

joyeecheung · 2018-11-11T18:34:26Z

@shisama Can you squash the commit before landing them? See https://github.com/nodejs/node/blob/7e1b178fb637abc68b1d4da1363a19db7ad02d6c/doc/guides/contributing/pull-requests.md#commit-squashing

shisama · 2018-11-12T15:48:48Z

@joyeecheung Thank you. I squashed them.

Refs: nodejs#22160

shisama · 2018-11-13T13:21:32Z

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/18575/

shisama · 2018-11-13T14:38:30Z

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/18578/

shisama · 2018-11-13T16:04:28Z

@BridgeAR Hi, is the label blocked still needed?

BridgeAR · 2018-11-13T16:06:26Z

I don't think so.

shisama · 2018-11-16T08:28:20Z

Resume Build for node-test-commit-arm-fanned: https://ci.nodejs.org/job/node-test-pull-request/18670/

Refs: #22160 PR-URL: #22478 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

shisama · 2018-11-16T13:06:02Z

Landed in 1e23e3c

Refs: nodejs#22160 PR-URL: nodejs#22478 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>

Refs: #22160 PR-URL: #22478 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Backport-PR-URL: #25446

Refs: nodejs#22160 PR-URL: nodejs#22478 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Backport-PR-URL: nodejs#25446

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) nodejs#24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) nodejs#24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) nodejs#25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) nodejs#25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) nodejs#22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) nodejs#25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) nodejs#25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) nodejs#25361 PR-URL: nodejs#25537

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) #24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) #24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) #25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) #25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) #22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) #25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) #25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) #25361 PR-URL: #25537

joyeecheung · 2019-01-24T22:12:09Z

I am removing semver-major since this should not result in observable changes while fs is in the internal binding whitelist.

BethGriggs · 2019-06-25T15:28:17Z

I've added the dont-land-on-v10.x label - but please let me know if you feel this should land on v10.x

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 23, 2018

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label Aug 23, 2018

jasnell mentioned this pull request Aug 23, 2018
Tracking Issue: process.binding to internalBinding #22160
Closed
33 tasks

shisama force-pushed the internal-binding-fs branch 3 times, most recently from 121225f to 69f7b28Compare August 25, 2018 02:52

shisama force-pushed the internal-binding-fs branch 2 times, most recently from 3dd21e1 to e367e77Compare August 31, 2018 10:01

BridgeAR approved these changes Aug 31, 2018
View reviewed changes

BridgeAR added the blocked PRs that are blocked by other issues or PRs. label Aug 31, 2018

jasnell previously approved these changes Sep 4, 2018
View reviewed changes

jasnell requested changes Sep 4, 2018
View reviewed changes

shisama force-pushed the internal-binding-fs branch 3 times, most recently from 8855aa7 to af2a68bCompare September 18, 2018 15:01

maxwellgerber mentioned this pull request Sep 28, 2018
Only works the first time tschaub/mock-fs#254
Closed

shisama force-pushed the internal-binding-fs branch from af2a68b to b7a5a87Compare October 17, 2018 01:10

lundibundi mentioned this pull request Nov 12, 2018
Implement new writable stream metarhia/metastreams#9
Closed

lundibundi approved these changes Nov 12, 2018
View reviewed changes

shisama force-pushed the internal-binding-fs branch from 98751dd to 7b2d4a8Compare November 12, 2018 15:46

shisama force-pushed the internal-binding-fs branch from 7b2d4a8 to 79834c9Compare November 13, 2018 01:23

fs: make process.binding('fs') internal
df729bc
Refs: nodejs#22160

shisama force-pushed the internal-binding-fs branch from 79834c9 to df729bcCompare November 13, 2018 13:14

BridgeAR removed the blocked PRs that are blocked by other issues or PRs. label Nov 13, 2018

shisama closed this Nov 16, 2018

joyeecheung mentioned this pull request Jan 11, 2019
src: use NativeModuleLoader to compile all the bootstrappers #24775
Closed
2 tasks

BridgeAR mentioned this pull request Jan 16, 2019
v11.7.0 proposal #25537
Merged

MylesBorins mentioned this pull request Jan 24, 2019
v11.8.0 proposal #25687
Merged

joyeecheung removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 24, 2019

BethGriggs added the dont-land-on-v10.x label Jun 25, 2019

Uh oh!

Uh oh!

Conversation

shisama commented Aug 23, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

addaleax commented Aug 23, 2018

Uh oh!

addaleax commented Aug 23, 2018

Uh oh!

jasnell commented Aug 23, 2018

Uh oh!

jdalton commented Aug 23, 2018

Uh oh!

shisama commented Aug 25, 2018

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

jdalton commented Sep 4, 2018

Uh oh!

jasnell commented Sep 4, 2018

Uh oh!

targos commented Sep 4, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Sep 4, 2018

Uh oh!

jasnell commented Sep 4, 2018

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Sep 5, 2018

Uh oh!

shisama commented Oct 18, 2018

Uh oh!

joyeecheung commented Nov 11, 2018

Uh oh!

shisama commented Nov 12, 2018

Uh oh!

shisama commented Nov 13, 2018

Uh oh!

shisama commented Nov 13, 2018

Uh oh!

shisama commented Nov 13, 2018

Uh oh!

BridgeAR commented Nov 13, 2018

Uh oh!

shisama commented Nov 16, 2018

Uh oh!

shisama commented Nov 16, 2018

Uh oh!

joyeecheung commented Jan 24, 2019

Uh oh!

BethGriggs commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

shisama commented Aug 23, 2018•
edited
Loading

targos commented Sep 4, 2018•
edited
Loading