deps: upgrade npm to v6.5.0 by ljharb · Pull Request #25234 · nodejs/node

ljharb · 2018-12-26T22:54:31Z

I noticed that node v11.6 ships with an npm that reports a version of v6.5.0-next.0. This PR updates that to actual v6.5.0.

Checklist

followed instructions at https://github.com/nodejs/node/blob/master/doc/guides/maintaining-npm.md
make test-npm passes (running now)
commit message follows commit guidelines

ljharb · 2018-12-26T22:56:24Z

cc @MylesBorins @zkat @iarna

ljharb · 2018-12-26T23:59:25Z

Local test failures:

 not ok 9 - config properties list: projectData: # of elements
---
found: 2
wanted: 0
compare: ===
at:
line: 66
column: 5
file: test/tap/config-basic.js
type: global
function: isDeeplyDetails
stack: |
isDeeplyDetails (test/tap/config-basic.js:66:5)
test/tap/config-basic.js:77:7
Array.forEach (<anonymous>)
test/tap/config-basic.js:76:17
lib/config/core.js:83:7
Array.forEach (<anonymous>)
lib/config/core.js:82:13
f (node_modules/once/once.js:25:25)
finalize (lib/config/core.js:193:5)
afterExtras (lib/config/core.js:184:5)
node_modules/mkdirp/index.js:48:26
source: |
t.is(Object.keys(aa).length, Object.keys(bb).length, msg + ': # of elements')
...
not ok 51 - config by source -> project -> data: # of elements
---
found: 2
wanted: 0
compare: ===
at:
line: 66
column: 5
file: test/tap/config-basic.js
type: global
function: isDeeplyDetails
stack: |
isDeeplyDetails (test/tap/config-basic.js:66:5)
test/tap/config-basic.js:68:5
Array.forEach (<anonymous>)
isDeeplyDetails (test/tap/config-basic.js:67:19)
test/tap/config-basic.js:68:5
Array.forEach (<anonymous>)
isDeeplyDetails (test/tap/config-basic.js:67:19)
test/tap/config-basic.js:79:5
lib/config/core.js:83:7
Array.forEach (<anonymous>)
lib/config/core.js:82:13
f (node_modules/once/once.js:25:25)
finalize (lib/config/core.js:193:5)
afterExtras (lib/config/core.js:184:5)
node_modules/mkdirp/index.js:48:26
source: |
t.is(Object.keys(aa).length, Object.keys(bb).length, msg + ': # of elements')
...

MylesBorins · 2018-12-27T04:43:24Z

@ljharb is that test failing on master as well?

ljharb · 2018-12-27T08:33:59Z

Hmm, I'm seeing many more of the npm tests failing on master - but maybe I'm not running the tests properly. Some help, or independent confirmation, would be appreciated.

Trott · 2018-12-29T15:47:22Z

Definitely tests on master are failing. It appears to have been this way for years. I tried to bisect to find out when the last time make test-npm passed. It's possible I got it wrong because maybe it had multiple periods of being fixed amidst long stretches of being broken, but the earliest time I could find was 3 years ago! 😱

Going through failures now and seeing about fixing them, but it's going to be slow-going. For example: #22519 (comment)

If you're seeing fewer test failures with the newer npm, that's probably a sign that a bunch of things have been fixed. I'd call that success.

jasnell · 2018-12-29T15:50:12Z

Might be about time to revisit the question of whether we really need npm in our source tree. Sure, we can still huddle it in builds, but having it in the repo likely no longer makes sense (if it ever did).

ljharb · 2018-12-29T15:55:48Z

In that case, can this land and go out in an 11.6.1? :-D

Trott

RSLGTM

Trott · 2018-12-30T23:45:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19879/

ljharb · 2018-12-31T02:11:32Z

@Trott any idea why that one FreeBSD job failed?

Trott · 2018-12-31T03:28:59Z

@Trott any idea why that one FreeBSD job failed?

Known problem with the test that makes it fail from time to time.

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19889/

Trott · 2018-12-31T04:01:40Z

Hmmm...same FreeBSD failure. That's not reassuring. But it seems very unlikely to actually be related. Let's try one more time: https://ci.nodejs.org/job/node-test-pull-request/19890/ ✅

ljharb · 2018-12-31T04:47:07Z

Yay, looks like that passed

Trott · 2019-01-03T03:20:44Z

This is now 7 days old, has one approval, and a green CI. It can land. However, I'd really like it if it had a second pair of eyes giving it a review. Anyone? @nodejs/npm @lance

lance

Looks good to me. I had the same failures, plus an additional three due to the fact that I have git configured to sign my commits. Updating my config with commit.gpgsign=false for deps/npm seemed to resolve the additional three I was seeing.

lance · 2019-01-03T16:04:30Z

Landed in aea5229

PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

PR-URL: nodejs#25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) nodejs#24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) nodejs#24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) nodejs#25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) nodejs#25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) nodejs#22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) nodejs#25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) nodejs#25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) nodejs#25361 PR-URL: nodejs#25537

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) #24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) #24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) #25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) #25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) #22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) #25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) #25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) #25361 PR-URL: #25537

PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

deps: upgrade npm to v6.5.0
ed0a305

nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 26, 2018

Trott approved these changes Dec 30, 2018
View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 30, 2018

addaleax mentioned this pull request Jan 2, 2019
deps: upgrade npm to 6.5.0 release version #25317
Closed
4 tasks

lance mentioned this pull request Jan 2, 2019
npm version in 11.6.0 is a pre-release version #25311
Closed

lance reviewed Jan 3, 2019
View reviewed changes

lance closed this Jan 3, 2019

lance pushed a commit that referenced this pull request Jan 3, 2019
deps: upgrade npm to v6.5.0
aea5229
PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

ljharb deleted the npm-6.5.0 branch January 3, 2019 16:08

addaleax pushed a commit that referenced this pull request Jan 5, 2019
deps: upgrade npm to v6.5.0
9101591
PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

ljharb mentioned this pull request Jan 9, 2019
Plan for Node.js 11 Current releases nodejs/Release#397
Closed

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
deps: upgrade npm to v6.5.0
47d53c5
PR-URL: nodejs#25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

BridgeAR mentioned this pull request Jan 16, 2019
v11.7.0 proposal #25537
Merged

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
deps: upgrade npm to v6.5.0
c56f5aa
PR-URL: nodejs#25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

ljharb mentioned this pull request Jan 17, 2019
test: ensure npm version is not release candidate #25538
Closed

Trott added the notable-change PRs with changes that should be highlighted in changelogs. label Jan 17, 2019

MylesBorins mentioned this pull request Jan 24, 2019
v11.8.0 proposal #25687
Merged

targos mentioned this pull request May 7, 2019
v10.16.0 proposal #27514
Merged

BethGriggs pushed a commit that referenced this pull request May 10, 2019
deps: upgrade npm to v6.5.0
d8b5e62
PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

MylesBorins pushed a commit that referenced this pull request May 16, 2019
deps: upgrade npm to v6.5.0
e880904
PR-URL: #25234 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>

ljharb mentioned this pull request Oct 29, 2019
deps: upgrade npm to v6.12.1 #30168
Closed
2 tasks

Uh oh!

Uh oh!

Conversation

ljharb commented Dec 26, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ljharb commented Dec 26, 2018

Uh oh!

ljharb commented Dec 26, 2018

Uh oh!

MylesBorins commented Dec 27, 2018

Uh oh!

ljharb commented Dec 27, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 29, 2018

Uh oh!

jasnell commented Dec 29, 2018

Uh oh!

ljharb commented Dec 29, 2018

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Dec 30, 2018

Uh oh!

ljharb commented Dec 31, 2018

Uh oh!

Trott commented Dec 31, 2018

Uh oh!

Trott commented Dec 31, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb commented Dec 31, 2018

Uh oh!

Trott commented Jan 3, 2019

Uh oh!

lance left a comment

Choose a reason for hiding this comment

Uh oh!

lance commented Jan 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ljharb commented Dec 26, 2018•
edited
Loading

ljharb commented Dec 27, 2018•
edited
Loading

Trott commented Dec 31, 2018•
edited
Loading