tools,icu: read full ICU version info from file by refack · Pull Request #23269 · nodejs/node

refack · 2018-10-04T20:47:15Z

ATM on every ICU version bump we need to update these data.
Reading it from a file makes it independant of configre.py changes.

Refs: #23245

Manual output:

D:\bin\dev\python27\python.exe configure.py --with-intl=full-icu --download=all
WARNING: * ECMA-402 (Intl) support didn't find ICU in deps/icu..
<https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip>
Fetch: | 24.1MB total, 24.1MB downloaded Checking file integrity with MD5:
MD5: 408854f7b9b58311b68fab4b4dfc80be deps\icu4c-62_1-src.zip
Extracting zipfile: deps\icu4c-62_1-src.zip
WARNING: warnings were emitted in the configure phase
Warning: Missing input files:
tools\msvs\genfiles\node_etw_provider.rc
tools\msvs\genfiles\node_etw_provider.h
Process finished with exit code 0

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-10-04T20:47:16Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1127/pipeline

addaleax · 2018-10-04T20:49:44Z

LGTM

Can you expand the commit message to explain the purpose of this change, for future generations?

refack · 2018-10-04T20:50:28Z

/CC @nodejs/build-files @nodejs/intl

refack · 2018-10-04T20:51:34Z

Can you expand the commit message to explain the purpose of this change, for future generations?

Will do. I need to coordinate with @srl295 so we don't conflict on doc changes.

srl295 · 2018-10-04T21:29:17Z

@refack I landed #23266 so go ahead

srl295 · 2018-10-04T21:30:23Z

@srl295 srl295 assigned refack just now

for future generations :)

richardlau

Typos in commit message:
independant->independent
configre.py->configure.py

mhdawson

LGTM

refack · 2018-10-05T22:20:37Z

Updated guide. PTAL

refack · 2018-10-08T20:29:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17686/

* ATM on every ICU version bump we need to update these data. Reading it from a file makes it independant of `configre.py` changes. * Update guide. PR-URL: nodejs#23269 Refs: nodejs#23245 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

* ATM on every ICU version bump we need to update these data. Reading it from a file makes it independant of `configre.py` changes. * Update guide. PR-URL: #23269 Refs: #23245 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Building on nodejs#23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. nodejs#23244 PR-URL: nodejs#23715Fixes: nodejs#22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

drewfish · 2018-10-24T16:30:50Z

Thank you! This is making tooling in my company much easier :)

srl295 · 2018-10-24T17:01:44Z

@drewfish how so? What's your use case? I'm looking at changing this file. Do you need to use a particular ICU version?

drewfish · 2018-10-24T22:31:30Z

We use the "full" ICU but don't otherwise need a particular version. We put some effort into "build resiliency" so that if the rest of the internet goes away we can still run our build pipelines as needed. To help with this we cache any "external file" that are part of the build, in this case the ICU tarball from sourceforge.

drewfish · 2018-10-24T22:32:44Z

Feel free to change/move the file, I'll track the change. (I was previously grepping the ICU URL out of configure.py :) )

refack · 2018-10-25T00:28:54Z

Thank you @drewfish for the feedback. Feel free to open issues (or PRs ;) for things that could improve your workflow.

srl295 · 2018-10-25T00:36:22Z

@drewfish i ask because I was thinking of moving (copying) the file with URLs upstream into ICU eventually.

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

* ATM on every ICU version bump we need to update these data. Reading it from a file makes it independant of `configre.py` changes. * Update guide. PR-URL: #23269 Refs: #23245 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Building on #23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. #23244 PR-URL: #23715Fixes: #22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Building on nodejs#23269, if multiple ICU download URLs are present, try the next one in case of error. Part of the ICU 63.1 bump, but independent code-wise. nodejs#23244 PR-URL: nodejs#23715Fixes: nodejs#22344 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> (cherry picked from commit d8f2d27)

nodejs-github-bot added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory. labels Oct 4, 2018

refack requested a review from srl295 October 4, 2018 20:47

refack force-pushed the refactor-out-ICU-dep branch 2 times, most recently from 29d632a to 8360275Compare October 4, 2018 20:55

srl295 approved these changes Oct 4, 2018
View reviewed changes

srl295 assigned refack Oct 4, 2018

srl295 mentioned this pull request Oct 5, 2018
tools: fix ICU shrinker and docs #23266
Merged
3 tasks

jasnell approved these changes Oct 5, 2018
View reviewed changes

richardlau approved these changes Oct 5, 2018
View reviewed changes

lpinca approved these changes Oct 5, 2018
View reviewed changes

mhdawson approved these changes Oct 5, 2018
View reviewed changes

refack force-pushed the refactor-out-ICU-dep branch from 8360275 to b853659Compare October 5, 2018 22:20

trivikr approved these changes Oct 6, 2018
View reviewed changes

refack force-pushed the refactor-out-ICU-dep branch from b853659 to be346d9Compare October 12, 2018 00:20

refack removed their assignment Oct 12, 2018

refack merged commit be346d9 into nodejs:masterOct 12, 2018

refack deleted the refactor-out-ICU-dep branch October 12, 2018 00:22

codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed

codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged

Uh oh!

Uh oh!

Conversation

refack commented Oct 4, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Oct 4, 2018

Uh oh!

addaleax commented Oct 4, 2018

Uh oh!

refack commented Oct 4, 2018

Uh oh!

refack commented Oct 4, 2018

Uh oh!

srl295 commented Oct 4, 2018

Uh oh!

srl295 commented Oct 4, 2018

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

refack commented Oct 5, 2018

Uh oh!

refack commented Oct 8, 2018

Uh oh!

drewfish commented Oct 24, 2018

Uh oh!

srl295 commented Oct 24, 2018

Uh oh!

drewfish commented Oct 24, 2018

Uh oh!

drewfish commented Oct 24, 2018

Uh oh!

refack commented Oct 25, 2018

Uh oh!

srl295 commented Oct 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

refack commented Oct 4, 2018•
edited
Loading