Skip to content

tools,icu: read full ICU version info from file#23269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
refack merged 1 commit into from
Oct 12, 2018
Merged

tools,icu: read full ICU version info from file #23269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions configure.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
importjson
importsys
importerrno
importoptparse
Expand DownExpand Up@@ -1234,13 +1235,9 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
returnlist

defconfigure_intl(o):
icus= [
{
'url': 'https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip',
'md5': '408854f7b9b58311b68fab4b4dfc80be',
},
]
deficu_download(path):
withopen('tools/icu/current_ver.dep') asf:
icus=json.load(f)
# download ICU, if needed
ifnotos.access(options.download_path, os.W_OK):
error('''Cannot write to desired download path.
Expand Down
8 changes: 4 additions & 4 deletions tools/icu/README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -92,9 +92,9 @@ make clean
tools/license-builder.sh
```

- Now, fix the default URL for the `full-icu` build in `/configure.py`, in
the `configure_intl()` function. It should match the ICU URL used in the
first step. When this is done, the following should build with full ICU.
- Update the URL and hash for the full ICU file in `tools/icu/current_ver.dep`.
It should match the ICU URL used in the first step. When this is done, the
following should build with full ICU.

```shell
# clean up
Expand All@@ -104,7 +104,7 @@ make
make test-ci
```

- commit the change to `configure.py` along with the updated `LICENSE` file.
- commit the change to `tools/icu/current_ver.dep` and `LICENSE` files.

- Note: To simplify review, I often will “pre-land” this patch, meaning that
I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch
Expand Down
6 changes: 6 additions & 0 deletions tools/icu/current_ver.dep
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
[
{
"url": "https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip",
"md5": "408854f7b9b58311b68fab4b4dfc80be"
}
]