deps: backport 525b396195 from upstream V8 by psmarshall · Pull Request #23827 · nodejs/node

psmarshall · 2018-10-23T08:50:08Z

Original commit message:

[cpu-profiler] Fix a leak caused by re-logging existing functions.

Don't re-log all existing functions during StartProcessorIfNotStarted().
They will already be in the CodeMap attached to the ProfileGenerator and
re-logging them causes leaks. See the linked bug for more details.

Bug: v8:8253
Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e
Reviewed-on: https://chromium-review.googlesource.com/1256763
Commit-Queue: Peter Marshall petermarshall@chromium.org
Reviewed-by: Yang Guo yangguo@chromium.org
Cr-Commit-Position: refs/heads/master@{#56336}

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

This has landed on V8 7.0 (https://chromium-review.googlesource.com/c/v8/v8/+/1280443)

psmarshall · 2018-10-23T08:52:59Z

@Flarna FYI, here is the backport of the fix. I'll open a separate one for v8.x

targos · 2018-10-23T09:13:03Z

Refs: v8/v8@525b396

Flarna · 2018-10-23T09:22:07Z

Refs: #23070

mmarchini · 2018-10-23T14:39:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/18077/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1781/

refack · 2018-10-23T17:10:55Z

Some failures might be fixed with #23733

psmarshall · 2018-10-30T10:43:54Z

I've rebased, could we run the CI & V8 CI again now that #23733 has been backported to 10?

refack · 2018-10-30T14:13:41Z

could we run the CI & V8 CI again

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1800/
PR CI: https://ci.nodejs.org/job/node-test-pull-request/18229/

Trott · 2018-11-02T02:24:30Z

Are the V8 CI failures expected?

refack · 2018-11-02T02:48:44Z

It's an escalated (-Werror) deprecation warning.
So half expected, as in expected some deprecated function use, not expected for it to fail the build.

10:24:07 ../../src/inspector/v8-console-message.cc:163:34: error: 'ToString' is deprecated [-Werror,-Wdeprecated-declarations]
10:24:07 bool result = append(bigint->ToString());
10:24:07 ^
10:24:07 ../../include/v8.h:2454:10: note: 'ToString' has been explicitly marked deprecated here
10:24:07 inline V8_DEPRECATED("Use maybe version", Local<String> ToString() const);
10:24:07 ^
10:24:07 ../../include/v8config.h:327:29: note: expanded from macro 'V8_DEPRECATED'

psmarshall · 2018-11-02T09:14:08Z

This PR doesn't touch any of that code, so I guess the V8 CI would also fail without this PR?

targos · 2018-11-02T09:18:48Z

V8 CI run on v10.x-staging to compare: https://ci.nodejs.org/job/node-test-commit-v8-linux/1806/

psmarshall · 2018-11-02T09:19:19Z

I confirmed locally that it does fail without this PR

psmarshall · 2018-11-02T09:26:02Z

I'll bisect 👍

richardlau · 2018-11-02T09:26:43Z

It's an escalated (-Werror) deprecation warning.
So half expected, as in expected some deprecated function use, not expected for it to fail the build.

10:24:07 ../../src/inspector/v8-console-message.cc:163:34: error: 'ToString' is deprecated [-Werror,-Wdeprecated-declarations]
10:24:07 bool result = append(bigint->ToString());
10:24:07 ^
10:24:07 ../../include/v8.h:2454:10: note: 'ToString' has been explicitly marked deprecated here
10:24:07 inline V8_DEPRECATED("Use maybe version", Local<String> ToString() const);
10:24:07 ^
10:24:07 ../../include/v8config.h:327:29: note: expanded from macro 'V8_DEPRECATED'

46c7d0d changed some V8_DEPRECATE_SOON to V8_DEPRECATED (including the one on line 2454 of v8.h that errored here).

psmarshall · 2018-11-02T09:30:17Z

Yep looks like that's the one. We could partially revert that CL (just the ones that are still in use) or backport the usage of the new APIs from V8

refack · 2018-11-02T09:31:29Z

I had a strong intuition that it was my fault... But our V8 CI builds with GN, so maybe it's not a GYP bug...

Trott · 2018-11-02T20:58:56Z

Should we remove author ready from this? Or is this OK to land in 10.x as-is?

psmarshall · 2018-11-06T15:21:15Z

I'll submit another CL to fix the v8 CI on v10x-staging and then we can re-run it here and land this, so this is blocked at the moment

psmarshall · 2018-11-06T17:36:25Z

Blocked on: #24195

psmarshall · 2018-11-07T17:43:46Z

New CI run now that the CI is green:

CI: https://ci.nodejs.org/job/node-test-pull-request/18405/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1823/

Original commit message: [cpu-profiler] Fix a leak caused by re-logging existing functions. Don't re-log all existing functions during StartProcessorIfNotStarted(). They will already be in the CodeMap attached to the ProfileGenerator and re-logging them causes leaks. See the linked bug for more details. Bug: v8:8253 Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e Reviewed-on: https://chromium-review.googlesource.com/1256763 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#56336}

psmarshall · 2018-11-09T09:14:57Z

Fixed up v8_embedder_string and rebased, running CI again (there was a wasm test flake)

CI: https://ci.nodejs.org/job/node-test-pull-request/18449/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1829/

psmarshall · 2018-11-12T09:51:06Z

V8 CI is green, CI is 'unstable' but looks ok. Can this be landed? @MylesBorins

MylesBorins · 2018-11-12T12:59:23Z

landed in 1e9b4a2

Original commit message: [cpu-profiler] Fix a leak caused by re-logging existing functions. Don't re-log all existing functions during StartProcessorIfNotStarted(). They will already be in the CodeMap attached to the ProfileGenerator and re-logging them causes leaks. See the linked bug for more details. Bug: v8:8253 Change-Id: Ibb1a1ab2431c588e8c3a3a9ff714767cdf61a88e Reviewed-on: https://chromium-review.googlesource.com/1256763 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56336} PR-URL: #23827 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Oct 23, 2018

targos approved these changes Oct 23, 2018
View reviewed changes

mmarchini approved these changes Oct 23, 2018
View reviewed changes

mmarchini added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2018

jasnell approved these changes Oct 23, 2018
View reviewed changes

refack approved these changes Oct 23, 2018
View reviewed changes

refack mentioned this pull request Oct 23, 2018
build: spawn make test-ci with -j1#23733
Merged
3 tasks

addaleax force-pushed the v10.x-staging branch from 8b431ad to 3f63297Compare October 27, 2018 08:14

MylesBorins force-pushed the v10.x-staging branch from 3f63297 to 8e7a12fCompare October 30, 2018 08:43

psmarshall force-pushed the backport_525b396195 branch 2 times, most recently from b417494 to 3bf52e2Compare October 30, 2018 10:41

richardlau added the blocked PRs that are blocked by other issues or PRs. label Nov 6, 2018

psmarshall removed the blocked PRs that are blocked by other issues or PRs. label Nov 7, 2018

psmarshall force-pushed the backport_525b396195 branch from 3bf52e2 to ff09700Compare November 9, 2018 09:09

psmarshall force-pushed the backport_525b396195 branch from ff09700 to 1e6a0b1Compare November 9, 2018 09:10

psmarshall mentioned this pull request Nov 9, 2018
deps: cherry-pick b87d408 from upstream V8 #24272
Closed
2 tasks

MylesBorins closed this Nov 12, 2018

codebytere mentioned this pull request Nov 27, 2018
v10.13.1 proposal #24675
Closed

codebytere mentioned this pull request Nov 29, 2018
v10.14.2 proposal #24727
Merged

Flarna mentioned this pull request Dec 13, 2018
Memory Leak in V8 CpuProfiler #23070
Closed

Uh oh!

Uh oh!

Conversation

psmarshall commented Oct 23, 2018

Checklist

Uh oh!

psmarshall commented Oct 23, 2018

Uh oh!

targos commented Oct 23, 2018

Uh oh!

Flarna commented Oct 23, 2018

Uh oh!

mmarchini commented Oct 23, 2018

Uh oh!

refack commented Oct 23, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

psmarshall commented Oct 30, 2018

Uh oh!

refack commented Oct 30, 2018

Uh oh!

Trott commented Nov 2, 2018

Uh oh!

refack commented Nov 2, 2018

Uh oh!

psmarshall commented Nov 2, 2018

Uh oh!

targos commented Nov 2, 2018

Uh oh!

psmarshall commented Nov 2, 2018

Uh oh!

psmarshall commented Nov 2, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Nov 2, 2018

Uh oh!

psmarshall commented Nov 2, 2018

Uh oh!

refack commented Nov 2, 2018

Uh oh!

Trott commented Nov 2, 2018

Uh oh!

psmarshall commented Nov 6, 2018

Uh oh!

psmarshall commented Nov 6, 2018

Uh oh!

psmarshall commented Nov 7, 2018

Uh oh!

psmarshall commented Nov 9, 2018

Uh oh!

psmarshall commented Nov 12, 2018

Uh oh!

MylesBorins commented Nov 12, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

refack commented Oct 23, 2018•
edited
Loading

psmarshall commented Nov 2, 2018•
edited
Loading