Uh oh!
There was an error while loading. Please reload this page.
deps: partially revert 'increase V8 deprecation levels' - #24195
Closed
psmarshall wants to merge 1 commit into
Closed
deps: partially revert 'increase V8 deprecation levels'#24195psmarshall wants to merge 1 commit into
psmarshall wants to merge 1 commit into
Conversation
addaleax
approved these changes
Nov 6, 2018
psmarshall
commented
Nov 6, 2018
ContributorAuthor
2 tasks
richardlau
approved these changes
Nov 6, 2018
refack
approved these changes
Nov 7, 2018
refack
commented
Nov 7, 2018
Contributor
Note to self: make a semver-patch backport of #23426 |
psmarshall
commented
Nov 7, 2018
ContributorAuthor
Redoing the linter because it failed: https://ci.nodejs.org/job/node-linter/1510/ |
Contributor
It has a rebasing checksum issue. Not relevant for linting. |
psmarshall
commented
Nov 7, 2018
ContributorAuthor
Thanks @refack. This is ready to land - @MylesBorins could you please land? Thanks 😀 |
MylesBorins
commented
Nov 7, 2018
Contributor
Landed in 2290c31 |
MylesBorins pushed a commit
that referenced
this pull request
Nov 7, 2018
PR-URL: #24195 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
rvagg pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24195 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 29, 2018
PR-URL: #24195 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThe V8 CI on
v10x-stagingwon't build because deprecation warnings are raised to errors at compile time. This is a partial revert of #23159 so that the build can run again.