Skip to content

doc: add shisama to collaborators - #24136

Closed
shisama wants to merge 1 commit into
nodejs:masterfrom
shisama:adding-shisama-as-collaborator
Closed

doc: add shisama to collaborators#24136
shisama wants to merge 1 commit into
nodejs:masterfrom
shisama:adding-shisama-as-collaborator

Conversation

@shisama

@shisamashisama commented Nov 6, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist

Fixes: #23850

@nodejs-github-bot

nodejs-github-bot commented Nov 6, 2018

Copy link
Copy Markdown
Collaborator

@shisama build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1513/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 6, 2018
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2018
View reviewed changes
Comment threadREADME.md Outdated
gireeshpunathil
gireeshpunathil reviewed Nov 6, 2018
View reviewed changes
Comment threadREADME.md Outdated
@shisama
shisamaforce-pushed the adding-shisama-as-collaborator branch from 4e5d2a1 to 9229971CompareNovember 6, 2018 14:50
@shisamashisama added notable-change PRs with changes that should be highlighted in changelogs. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 6, 2018
@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 6, 2018
@joyeecheung

joyeecheung commented Nov 6, 2018

Copy link
Copy Markdown
Member

I suggested @shisama to start a full CI, because the bot already kicks off the lite CI pipeline but we need to teach people how to use the CI during the onboarding process

@shisama

shisama commented Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/18369/

shisama pushed a commit that referenced this pull request Nov 6, 2018
Masashi Hirano
doc: add shisama to collaborators
a49b672
PR-URL: #24136Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@shisama

shisama commented Nov 6, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in a49b672

@shisamashisama closed this Nov 6, 2018
targos pushed a commit that referenced this pull request Nov 6, 2018
Masashi Hirano@targos
doc: add shisama to collaborators
f9f185a
PR-URL: #24136Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
b0e07c5
Notable changes:
* child_process:
* All child processes will again open up a new Window on Windows by
default. [#24034](#24034)
* deps:
* A new and fast experimental HTTP parser (`llhttp`) is now supported.
[#24059](#24059)
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
[#24300](#24300)
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
[#24170](#24170)
* [shisama](https://github.com/shisama) - Masashi Hirano.
[#24136](#24136)
@BridgeARBridgeAR mentioned this pull request Nov 14, 2018
Merged
BridgeAR added a commit that referenced this pull request Nov 14, 2018
@BridgeAR
2018-11-15, Version 11.2.0 (Current)
f410a6d
Notable changes:
* child_process:
* All child processes will again open up a new Window on Windows by
default. [#24034](#24034)
* deps:
* A new and fast experimental HTTP parser (`llhttp`) is now supported.
[#24059](#24059)
* **Windows**
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
[#23822](#23822)
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
[#24300](#24300)
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
[#24170](#24170)
* [shisama](https://github.com/shisama) - Masashi Hirano.
[#24136](#24136)
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Masashi Hirano@kiyomizumia
doc: add shisama to collaborators
9977dd4
PR-URL: nodejs#24136Fixes: nodejs#23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR@targos
2018-11-15, Version 11.2.0 (Current)
a19e1ab
Notable changes:
* deps:
* A new experimental HTTP parser (`llhttp`) is now supported.
#24059
* timers:
* Fixed an issue that could cause setTimeout to stop working as
expected. #24322
* Windows
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
#23822
* Continued effort to improve the installer's new stage that installs
native build tools.
#23987,
#24348
* child_process:
* On Windows the `windowsHide` option default was restored to
`false`. This means `detached` child processes and GUI apps will
once again start in a new window.
#24034
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
#24300
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
#24170
* [shisama](https://github.com/shisama) - Masashi Hirano.
#24136
targos pushed a commit that referenced this pull request Nov 15, 2018
@BridgeAR@targos
2018-11-15, Version 11.2.0 (Current)
406d9ca
Notable changes:
* deps:
* A new experimental HTTP parser (`llhttp`) is now supported.
#24059
* timers:
* Fixed an issue that could cause setTimeout to stop working as
expected. #24322
* Windows
* A crashing process will now show the names of stack frames if the
node.pdb file is available.
#23822
* Continued effort to improve the installer's new stage that installs
native build tools.
#23987,
#24348
* child_process:
* On Windows the `windowsHide` option default was restored to
`false`. This means `detached` child processes and GUI apps will
once again start in a new window.
#24034
* Added new collaborators:
* [oyyd](https://github.com/oyyd) - Ouyang Yadong.
#24300
* [psmarshall](https://github.com/psmarshall) - Peter Marshall.
#24170
* [shisama](https://github.com/shisama) - Masashi Hirano.
#24136
PR-URL: #24350
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
Masashi Hirano@codebytere
doc: add shisama to collaborators
5f14b4e
PR-URL: #24136Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
Masashi Hirano@MylesBorins
doc: add shisama to collaborators
f80423b
PR-URL: #24136Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@codebyterecodebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
Masashi Hirano@MylesBorins
doc: add shisama to collaborators
ec43b32
PR-URL: #24136Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 6, 2018
@codebytere@MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
4128793
Notable changes:
* deps:
* upgrade to c-ares v1.15.0 (Ben Noordhuis)
#23854
* Windows:
* A crashing process will now show the names of stack frames if the node.pdb
file is available. (Refael Ackermann)
#23822
* Added new collaborators:
* Peter Marshall. #24170
* Masashi Hirano. #24136
PR-URL: #24727
MylesBorins pushed a commit that referenced this pull request Dec 11, 2018
@codebytere@MylesBorins
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
6c6c563
Notable changes:
* deps:
* upgrade to c-ares v1.15.0 (Ben Noordhuis)
#23854
* Windows:
* A crashing process will now show the names of stack frames if the node.pdb
file is available. (Refael Ackermann)
#23822
* Added new collaborators:
* Peter Marshall. #24170
* Masashi Hirano. #24136
PR-URL: #24727
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@codebytere@refack
2018-12-11, Version 10.14.2 'Dubnium' (LTS)
a2fa589
Notable changes:
* deps:
* upgrade to c-ares v1.15.0 (Ben Noordhuis)
nodejs#23854
* Windows:
* A crashing process will now show the names of stack frames if the node.pdb
file is available. (Refael Ackermann)
nodejs#23822
* Added new collaborators:
* Peter Marshall. nodejs#24170
* Masashi Hirano. nodejs#24136
PR-URL: nodejs#24727
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nominating @shisama as a collaborator

8 participants

@shisama@nodejs-github-bot@joyeecheung@targos@cjihrig@gireeshpunathil@vsemozhetbyt@codebytere