Uh oh!
There was an error while loading. Please reload this page.
win: add customization warning to tools script - #24348
Closed
joaocgreis wants to merge 1 commit into
Closed
Conversation
refack
approved these changes
Nov 13, 2018
Contributor
I'm not against clear text, but its effectiveness is limited, especially IMO when it's long. Ohh there's a GUI to create WinForms - https://poshgui.com https://theitbros.com/powershell-gui-for-scripts/ |
joaocgreis
commented
Nov 14, 2018
MemberAuthor
Please upvote this comment to approve fast-tracking, it would be good if this could make it into v11.2.0. cc @refack (as requested in collaborator guide) CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/18598/ |
refack
commented
Nov 14, 2018
Contributor
Need another upvote. @nodejs/platform-windows @tniessen @nodejs/build-files |
refack
commented
Nov 14, 2018
Contributor
/CC @nodejs/documentation |
vsemozhetbyt
approved these changes
Nov 14, 2018
Trott
commented
Nov 14, 2018
Member
Resume Build CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/18607/ |
joaocgreis
commented
Nov 14, 2018
MemberAuthor
Resumed CI green, landed in 3856d8a. Thanks! |
joaocgreis added a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24348 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
joaocgreis
commented
Nov 14, 2018
MemberAuthor
LTS: Depends on #24344, for now it looks like the revert is going forward so I'll add the don't land label here. |
BridgeAR pushed a commit
that referenced
this pull request
Nov 15, 2018
PR-URL: #24348 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
targos pushed a commit
that referenced
this pull request
Nov 15, 2018
Notable changes: * deps: * A new experimental HTTP parser (`llhttp`) is now supported. #24059 * timers: * Fixed an issue that could cause setTimeout to stop working as expected. #24322 * Windows * A crashing process will now show the names of stack frames if the node.pdb file is available. #23822 * Continued effort to improve the installer's new stage that installs native build tools. #23987, #24348 * child_process: * On Windows the `windowsHide` option default was restored to `false`. This means `detached` child processes and GUI apps will once again start in a new window. #24034 * Added new collaborators: * [oyyd](https://github.com/oyyd) - Ouyang Yadong. #24300 * [psmarshall](https://github.com/psmarshall) - Peter Marshall. #24170 * [shisama](https://github.com/shisama) - Masashi Hirano. #24136
targos pushed a commit
that referenced
this pull request
Nov 15, 2018
Notable changes: * deps: * A new experimental HTTP parser (`llhttp`) is now supported. #24059 * timers: * Fixed an issue that could cause setTimeout to stop working as expected. #24322 * Windows * A crashing process will now show the names of stack frames if the node.pdb file is available. #23822 * Continued effort to improve the installer's new stage that installs native build tools. #23987, #24348 * child_process: * On Windows the `windowsHide` option default was restored to `false`. This means `detached` child processes and GUI apps will once again start in a new window. #24034 * Added new collaborators: * [oyyd](https://github.com/oyyd) - Ouyang Yadong. #24300 * [psmarshall](https://github.com/psmarshall) - Peter Marshall. #24170 * [shisama](https://github.com/shisama) - Masashi Hirano. #24136 PR-URL: #24350
This was referenced Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script introduced in #22645 to install Visual Studio and Python on Windows should work reliably in most scenarios. But it can only go so far, if a user wants to customize the installation or has custom policies in place, the alternative installation methods should be used. The script is designed to be as simple as possible, because for other options and customization there are already detailed instructions that the users can follow.
This PR adds a warning about that.
cc @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes