tools: Use print() function on both Python 2 and 3

[cclauss]

A subset of #23669 to simplify the review process. @refack@addaleax

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

Is there any chance of the GYP patches being upstreamed? If not, it would be great to finally do the thing where we pull changes from our own fork of it…

[cclauss]

@addaleaxWorking on that in parallel. It would be a lot easier is we pip installed our Python dependencies instead of vendoring them in.

[Trott]

@nodejs/python

[refack]

@cclauss thank you for making it easier to review.
IMHO you should exclude tools/gyp. For that I'm going to port your patch from nodejs/node-gyp#1335 since it has already received test coverage.
(I plan to do it VIA refack/GYP, once I get the GYP CI test suite revived)

[refack]

Should exclude tools/GYP and tools/inspector_protocol

[refack]

P.S. I'm self-assigned this so I'll get notifications from Github, and so that I will not lose track of it and help steward it to completion.

[thefourtheye]

Nit: This would be better if it followed the copyright notice.

[refack]

This isn't our code. It should be patched upstream at https://chromium.googlesource.com/deps/inspector_protocol/

[thefourtheye]

Ah, okay. Sure, this has to be updated in upstream then.

[refack]

@cclauss Sorry I didn't notice this before.

[cclauss]

I will remove inspector_protocol from this PR.

However this opens up a can of worms that I do not have a solution for. Chromium in general and v8 specifically are not on GitHub. Their GitHub mirror does not accept pull requests. The v8 repo is just 1.4% Python but that is all legacy Python and at least 76 files need to be modified just to fix the print statement which is merely the start of a Python 3 port. v8 is a venerable codebase and I often hear that it was a godsend to the JavaScript community but its Python code needs to be modernized, removed, or replaced with JavaScript, Go, etc. 407 days until Python 2 end of life. @hugovk your expert advise here please.

[refack]

So they do accept PRs (which they call CLs) you just need to do it their way:
https://v8.dev/docs/contribute
As for inspector_protocol it's a sub project so submitting patches should be simpler.
/cc @aslushnikov@ak239

[aslushnikov]

As for inspector_protocol it's a sub project so submitting patches should be simpler.

It's quite similar for both v8 and inspector-protocol.

For the inspector-protocol, check out these links:

• repository: https://chromium.googlesource.com/deps/inspector_protocol/
• how to upload a patch: https://www.chromium.org/developers/contributing-code#TOC-Uploading-a-change-for-review

[refack]

@srl295 where do the python scripts in tools/icu/ come from?

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/18783/

[refack]

I will remove inspector_protocol from this PR.

The v8 repo is just 1.4% Python but that is all legacy Python and at least 76 files need to be modified just to fix the print statement which is merely the start of a Python 3 port.

@cclauss from the Node.js perspective, IMHO our first goal is to get the main build@test (a.k.a CI) workflow compatible with python3.
Since inspector_protocol is a code-gen tool we can workaround it by checking-in the generated code (#22680). We need to identify which other python scripts from V8 we use (via https://github.com/nodejs/node/blob/master/deps/v8/gypfiles/v8.gyp)

[cclauss]

Sounds like a good plan.

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/18805/

Reviewers please consider this for fast-tracking by 👍 .

[thefourtheye]

@srl295 where do the python scripts in tools/icu/ come from?

I looked at the git logs, it looks like its our own. Just to be sure, can we wait till @srl295 confirms?

[refack]

can we wait till @srl295 confirms?

ack.

[cclauss]

Should I break this into seven separate PRs to make it easier to review?

[srl295]

@refack sorry :( yes, they are 'our own'. I wrote them origianlly to be part of ICU, but the python scripts should be considered part of node.

Incidentally, ICU itself will require python for build-from-repo (not from tarball). At this point it will require python 2.7 or 3.

[srl295]

I really thought I +1'ed a similar change here. but anyway, post merge LGTM. There's no need to upstream ICU's .py files at this point.

[thefourtheye]

@srl295 Thanks for confirming 🙂

[srl295]

But on this point ICU as of 2 days ago does actually have its own slicer— please see #25136 and comment on the upstream design. This would replace node's special code (and it runs on python 2.7 and 3).