Skip to content

v10.15.3 proposal - #26063

Merged
BethGriggs merged 209 commits into
v10.xfrom
v10.15.2-proposal
Mar 5, 2019
Merged

v10.15.3 proposal#26063
BethGriggs merged 209 commits into
v10.xfrom
v10.15.2-proposal

Conversation

@BethGriggs

@BethGriggsBethGriggs commented Feb 12, 2019•
edited
Loading

Copy link
Copy Markdown
Member

2019-03-05, Version 10.15.3 'Dubnium' (LTS), @BethGriggs

Notable Changes

  • doc
    • add antsmartian to collaborators (Anto Aravinth) #24655
  • http
    • fix error check in Execute() (Brian White) #25863
  • stream
    • fix end-of-stream for HTTP/2 (Anna Henningsen) #24926

Commits

@nodejs-github-bot

nodejs-github-bot commented Feb 12, 2019

Copy link
Copy Markdown
Collaborator

@BethGriggs build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2584/pipeline

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 12, 2019
BethGriggs added a commit that referenced this pull request Feb 12, 2019
@BethGriggs
2019-02-26, Version 10.15.2 'Dubnium' (LTS)
7a2f782
Notable Changes
PR-URL: #26063
@BethGriggs

BethGriggs commented Feb 12, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/20746/ [PASSED]
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2090/ [PASSED]

@MylesBorins

MylesBorins commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1735/

BethGriggs added a commit that referenced this pull request Feb 13, 2019
@BethGriggs
2019-02-26, Version 10.15.2 'Dubnium' (LTS)
c103ae2
Notable Changes
PR-URL: #26063
@BethGriggs

BethGriggs commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

Pushed an extra two bug fixes.

CI2: https://ci.nodejs.org/job/node-test-pull-request/20764/
CITGM2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1737/

Kicked off an RC build.

@BethGriggs

BethGriggs commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

rc0: https://nodejs.org/download/rc/v10.15.2-rc.0/

BethGriggs added a commit that referenced this pull request Feb 19, 2019
@BethGriggs
2019-02-26, Version 10.15.2 'Dubnium' (LTS)
441a321
Notable Changes
PR-URL: #26063
@avaly

avaly commented Feb 20, 2019

Copy link
Copy Markdown

Is it possible to also include #25993 in this release?

BridgeAR
BridgeAR reviewed Feb 20, 2019
View reviewed changes
Comment threaddoc/api/tls.md Outdated
added: v0.11.13
changes:
- version: REPLACEME
- version: v10.15.2

@BridgeARBridgeARFeb 20, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this feature has never landed in v10.x (there is a backport for 10.x open. See #24979). I guess we should remove the changes entry until it actually lands?

@BethGriggsBethGriggsFeb 20, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, i'll back that one out

BethGriggs added a commit that referenced this pull request Feb 20, 2019
@BethGriggs
2019-02-26, Version 10.15.2 'Dubnium' (LTS)
ac4c04b
Notable Changes
PR-URL: #26063
@BethGriggs

BethGriggs commented Feb 21, 2019

Copy link
Copy Markdown
MemberAuthor

CI3: https://ci.nodejs.org/job/node-test-pull-request/20931/
V8-CI3: https://ci.nodejs.org/job/node-test-commit-v8-linux/2109/
CITGM3: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1745/

mhdawson
mhdawson approved these changes Feb 22, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg

rvagg commented Feb 26, 2019

Copy link
Copy Markdown
Member

We discussed postponing this by a week at the last TSC meeting due to the security releases. I'm not sure if that got spread around further than that meeting. So this is going to have to be 10.15.3.

@richardlaurichardlau mentioned this pull request Feb 26, 2019
Merged
ZYSzysand others added 3 commits February 28, 2019 23:37
@ZYSzys@rvagg
src: use v8:: for consistency in util
f9fc1ea
Backport-PR-URL: #25005
PR-URL: #23934
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@ofrobots@rvagg
deps: V8: backport 442977e
fa12b24
Original commit message:
Merged: [wasm] Fix dispatch table instance update
This CL fixes a bug where the receiving instance was updated improperly
in the dispatch table(s) of an imported table.
BUG=chromium:875322
R=​mstarzinger@chromium.org
CC=titzer@chromium.org
Change-Id: Iff24953a1fb6a8ab794e12a7a976d544b56fc3c2
Originally-reviewed-on: https://chromium-review.googlesource.com/1196886
No-Try: true
No-Presubmit: true
No-Treechecks: true
Reviewed-on: https://chromium-review.googlesource.com/1212922
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.9@{#45}
Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}
Refs: v8/v8@442977e
PR-URL: #25242
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@alexkozy@rvagg
deps: cherry-pick d9fbfeb from upstream V8
67239ab
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
Azardand others added 15 commits February 28, 2019 23:37
@Azard@rvagg
doc: add EventTarget link to worker_threads
f38469e
PR-URL: #25058
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@cjihrig@rvagg
doc: fix node.1 --http-parser sort order
2d54629
For consistency with the API docs, switch the order of
--http-parser and --force-fips in node.1.
PR-URL: #25045
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax@rvagg
perf_hooks: make GC tracking state per-Environment
7f48299
Otherwise this is global state that may be subject to race
conditions e.g. when running `perf_hooks` inside of Worker threads.
Tracking the GC type is removed entirely since the variable was unused.
PR-URL: #25053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig@rvagg
vm: simplify Script constructor options validation
5f2acc0
This commit combines two related if statements into an
if-else statement.
PR-URL: #25054
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cjihrig@rvagg
tools: enable no-useless-constructor lint rule
5c3a739
This commit enables ESLint's no-useless-constructor rule. Note
that the documentation examples that only include constructor
calls were left in tact.
PR-URL: #25055
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@sam-github@rvagg
test: merge test with unnecessary child process
d3c4cab
Test didn't require child process creation. While this test has not been
unstable, child process creation is slower and can be flaky in ci, so
test directly for the segfault regression.
PR-URL: #25025
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@sam-github@rvagg
tls: re-define max supported version as 1.2
161dca7
Several secureProtocol strings allow any supported TLS version as the
maximum, but our maximum supported protocol version is TLSv1.2 even if
someone configures a build against an OpenSSL that supports TLSv1.3.
Fixes: #24658
PR-URL: #25024
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott@rvagg
doc: revise "Breaking Changes" section of Collaborator Guide
801fb66
Simplify material about TSC approval for breaking changes. Omit
extraneous material explaining that purely additive changes are not
breaking changes.
PR-URL: #25071
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung@rvagg
tools: make apilinks building more robust
ef07faa
1. Move the apilinks.json file into out/doc so it gets cleaned when
running `make docclean`
2. When the apilinks.json generated is empty, throw a specific error
so it's easier to understand what's wrong
3. Write to a file passed through CLI arguments instead writing to
stdout in apilinks.js so the build process is more robust in
the case of a bad binary
PR-URL: #25019
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ZYSzys@rvagg
test: test internal/util/types in vm
078a2ba
PR-URL: #25056
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mcollina@rvagg
doc: document fs.write limitation with TTY
4bc212d
Fixes: #24550
PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@addaleax@rvagg
process: fix omitting -- from process.execArgv
3d6266a
This was essentially a typo that went unnoticed because we
didn’t have tests for this particular situation.
Fixes: #24647
PR-URL: #24654
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BridgeAR@rvagg
assert: fix loose deepEqual map comparison
9da4af7
Loose map comparison had an logic error. It will now be properly
compared.
PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR@rvagg
assert,util: fix sparse array comparison
30aa8b2
Comparing sparse arrays did not work properly. That is fixed and
tests were added to verify that everything works as expected.
This had an impact on `util.isDeepStrictEqual()` and
`assert.deepStrictEqual()` and their counterpart
`assert.notDeepStrictEqual()`.
PR-URL: #24749
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau@rvagg
build: set -blibpath: for AIX
156e4c8
#17604 refactored the gyp files
so that `-blibpath:` on AIX was only set if `node_shared=="true"`.
Restore the setting for non-shared builds.
Fixes: #25444
PR-URL: #25447
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs added a commit that referenced this pull request Feb 28, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
9f70f19
Notable Changes
PR-URL: #26063
@BethGriggsBethGriggs changed the title v10.15.2 proposalv10.15.3 proposalFeb 28, 2019
@BethGriggs

BethGriggs commented Feb 28, 2019•
edited by MylesBorins
Loading

Copy link
Copy Markdown
MemberAuthor

Rebased, new CIs

CI: https://ci.nodejs.org/job/node-test-pull-request/21050/ [Green]
V8CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2120/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1759/

BridgeAR
BridgeAR approved these changes Feb 28, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. Just the notable changes should still be filled in (if we have any).

Comment threaddoc/changelogs/CHANGELOG_V10.md Outdated
rvagg
rvagg reviewed Mar 1, 2019
View reviewed changes
Comment threaddoc/changelogs/CHANGELOG_V10.md

* **Coming soon**

### Commits

This comment was marked as outdated.

Sign in to view

@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
1a96d83
Notable Changes
* **doc**
* add antsmartian to collaborators (Anto Aravinth)
[#24655](#24655)
* **http**
* fix error check in Execute() (Brian White)
[#25863](#25863)
* **stream**
* fix end-of-stream for HTTP/2 (Anna Henningsen)
[#24926](#24926)
PR-URL: #26063
@BethGriggs
BethGriggs merged commit 1a96d83 into v10.xMar 5, 2019
BethGriggs added a commit that referenced this pull request Mar 5, 2019
@BethGriggs
Working on v10.15.4
f612a71
PR-URL: #26063
BethGriggs added a commit that referenced this pull request Mar 5, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
a52c1ea
Notable Changes
* **doc**
* add antsmartian to collaborators (Anto Aravinth)
[#24655](#24655)
* **http**
* fix error check in Execute() (Brian White)
[#25863](#25863)
* **stream**
* fix end-of-stream for HTTP/2 (Anna Henningsen)
[#24926](#24926)
PR-URL: #26063
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Mar 5, 2019
@BethGriggs
Blog: v10.15.3 release post
577a30b
Refs: nodejs/node#26063
@BethGriggsBethGriggs mentioned this pull request Mar 5, 2019
Merged
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Mar 5, 2019
@BethGriggs
Blog: v10.15.3 release post (#2140)
bb8be74
Refs: nodejs/node#26063
@BethGriggs
BethGriggs deleted the v10.15.2-proposal branch March 5, 2019 17:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@rvaggrvaggrvagg left review comments
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@BethGriggs@nodejs-github-bot@MylesBorins@avaly@rvagg@richardlau@BridgeAR@mhdawson@ZYSzys@ofrobots@alexkozy@devsnek@sam-github@mscdex@Jayasankar-m@prodroy1@yuriettys@sadnessOjisan@ka2jun8@kawanet