Skip to content

build: fix c++ code coverage on macOS - #24520

Merged
Trott merged 1 commit into
nodejs:masterfrom
refack:fixmaccppcoverage
Dec 1, 2018
Merged

build: fix c++ code coverage on macOS#24520
Trott merged 1 commit into
nodejs:masterfrom
refack:fixmaccppcoverage

Conversation

@refack

Copy link
Copy Markdown
Contributor

Alternative to #24004

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@refack sadly an error occured when I tried to trigger a build :(

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 20, 2018
@refackrefack mentioned this pull request Nov 20, 2018
2 tasks
@refack

Copy link
Copy Markdown
ContributorAuthor

@refackrefack added macos Issues and PRs related to the macOS platform / OSX. coverage Issues and PRs related to native coverage support. labels Nov 20, 2018
@refack

Copy link
Copy Markdown
ContributorAuthor

/CC @nodejs/build-files @nodejs/gyp

@refackrefack self-assigned this Nov 20, 2018
@refack

refack commented Nov 20, 2018

Copy link
Copy Markdown
ContributorAuthor

I tested this on https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/, and it builds and links
node.zip

But I get this from nyc:


> bash-3.2$ NODE_DEBUG=nyc ./node ./node_modules/.bin/nyc instrument --extension .js --extension .mjs --exit-on-error lib_/ lib/ > nyc.log 2> nyc.err
profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: mismatched number of counters (10)
profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: corrupt arc tag (0x344e496f)
.
.
.
Segmentation fault: 11

P.S. it's actually just the node binary:

> ./node -p 'process.version'
v12.0.0-pre
profiling: /Users/iojs/build/workspace/node/out/Release/obj.target/node_lib/src/async_wrap.gcda: cannot merge previous GCDA file: mismatched number of counters (10)
.
.
.

nyc.zip

@refack

Copy link
Copy Markdown
ContributorAuthor

/CC @nodejs/build-files @nodejs/gyp (CI had just a flake)

@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

PR-URL: nodejs#24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Trott merged commit eb6741b into nodejs:masterDec 1, 2018
@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

Landed in eb6741b

BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24520
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@refackrefack removed their assignment Mar 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.coverageIssues and PRs related to native coverage support.macosIssues and PRs related to the macOS platform / OSX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@Trott@addaleax@BethGriggs