Uh oh!
There was an error while loading. Please reload this page.
build: fix c++ code coverage on macOS - #24520
Merged
Merged
Conversation
nodejs-github-bot
commented
Nov 20, 2018
Collaborator
@refack sadly an error occured when I tried to trigger a build :( |
2 tasks
refack
commented
Nov 20, 2018
ContributorAuthor
addaleax
approved these changes
Nov 20, 2018
refack
commented
Nov 20, 2018
ContributorAuthor
/CC @nodejs/build-files @nodejs/gyp |
ContributorAuthor
I tested this on https://ci.nodejs.org/computer/test-macstadium-macos10.12-x64-1/, and it builds and links But I get this from P.S. it's actually just the node binary: |
refack
commented
Nov 26, 2018
ContributorAuthor
/CC @nodejs/build-files @nodejs/gyp (CI had just a flake) |
Trott
commented
Dec 1, 2018
Member
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19111/ |
Member
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott
commented
Dec 1, 2018
Member
Landed in eb6741b |
BridgeAR pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 7, 2018
refack added a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #24004
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes