Skip to content

doc: document fs.write limitation with TTY - #24571

Closed
mcollina wants to merge 3 commits into
nodejs:masterfrom
mcollina:docs-chcp
Closed

doc: document fs.write limitation with TTY#24571
mcollina wants to merge 3 commits into
nodejs:masterfrom
mcollina:docs-chcp

Conversation

@mcollina

@mcollinamcollina commented Nov 22, 2018

Copy link
Copy Markdown
Member

Fixes: #24550

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 22, 2018

Copy link
Copy Markdown
Collaborator

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1677/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 22, 2018
@mcollina

mcollina commented Nov 22, 2018

Copy link
Copy Markdown
MemberAuthor

cc @refack @nodejs/platform-windows

sam-github
sam-github reviewed Nov 22, 2018
View reviewed changes
Comment threaddoc/api/fs.md Outdated
Comment threaddoc/api/fs.md Outdated
refack
refack approved these changes Nov 22, 2018
View reviewed changes

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general.
I'm rubber-stamping any future phrasing changes.

Comment threaddoc/api/fs.md Outdated
Comment threaddoc/api/fs.md Outdated
Comment threaddoc/api/fs.md Outdated
@mcollina

mcollina commented Nov 22, 2018

Copy link
Copy Markdown
MemberAuthor

Updated with @refack changes (edited).
@sam-github please check it out.

refack
refack approved these changes Nov 22, 2018
View reviewed changes

@refackrefack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@refack

refack commented Nov 22, 2018

Copy link
Copy Markdown
Contributor

BTW: Is codepage 65001 as UTF-8, is common in POSIX land?

@mcollina

mcollina commented Nov 22, 2018

Copy link
Copy Markdown
MemberAuthor

BTW: Is codepage 65001 as UTF-8, is common in POSIX land?

I never experienced this problem in Linux or Mac.

seishun
seishun reviewed Nov 22, 2018
View reviewed changes
Comment threaddoc/api/fs.md Outdated
@mcollina

mcollina commented Nov 22, 2018

Copy link
Copy Markdown
MemberAuthor

@seishun PTAL

mhdawson
mhdawson approved these changes Nov 22, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once other peoples comments are addressed

@mcollina

mcollina commented Nov 23, 2018

Copy link
Copy Markdown
MemberAuthor

I think this should be ready to land after the 48 expires.

@mcollinamcollina added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2018
@mcollina

mcollina commented Nov 23, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1683/

addaleax
addaleax reviewed Nov 24, 2018
View reviewed changes
Comment threaddoc/api/fs.md Outdated
@addaleax@mcollina
Update doc/api/fs.md
aa1e3f4
Co-Authored-By: mcollina <matteo.collina@gmail.com>
seishun
seishun reviewed Nov 24, 2018
View reviewed changes
Comment threaddoc/api/fs.md
seishun
seishun reviewed Nov 24, 2018
View reviewed changes
Comment threaddoc/api/fs.md Outdated
@seishun@mcollina
Update doc/api/fs.md
85f4a5b
Co-Authored-By: mcollina <matteo.collina@gmail.com>
@mcollina

mcollina commented Nov 26, 2018

Copy link
Copy Markdown
MemberAuthor

I'm going to land this tomorrow morning CET.

@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1703/

@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Landed in 086482d

@TrottTrott closed this Nov 28, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2018
@mcollina@Trott
doc: document fs.write limitation with TTY
086482d
Fixes: nodejs#24550
PR-URL: nodejs#24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
targos pushed a commit that referenced this pull request Nov 28, 2018
@mcollina@targos
doc: document fs.write limitation with TTY
2ebb32b
Fixes: #24550
PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mcollina@refack
doc: document fs.write limitation with TTY
cd97c5f
Fixes: nodejs#24550
PR-URL: nodejs#24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@mcollina@BethGriggs
doc: document fs.write limitation with TTY
cfd5773
Fixes: #24550
PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@mcollina@BethGriggs
doc: document fs.write limitation with TTY
dbc01e1
Fixes: #24550
PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@mcollina@rvagg
doc: document fs.write limitation with TTY
4bc212d
Fixes: #24550
PR-URL: #24571
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax left review comments
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+6 more reviewers
@sam-githubsam-githubsam-github left review comments
@refackrefackrefack approved these changes
@seishunseishunseishun left review comments
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@mhdawsonmhdawsonmhdawson approved these changes
@bzozbzozbzoz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@mcollina@nodejs-github-bot@refack@Trott@sam-github@addaleax@seishun@gireeshpunathil@mhdawson@vsemozhetbyt@bzoz