Skip to content

lib: Convert to Arrow Function - #24615

Closed
darai0512 wants to merge 1 commit into
nodejs:masterfrom
darai0512:master
Closed

lib: Convert to Arrow Function#24615
darai0512 wants to merge 1 commit into
nodejs:masterfrom
darai0512:master

Conversation

@darai0512

@darai0512darai0512 commented Nov 24, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Converts to Arrow Function and tests it by ./tools/test.py tick-processor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Daiki Arai
lib: Convert to Arrow Function
8423ef3
Converts to Arrow Function and tests by `./tools/test.py tick-processor`
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 24, 2018
@hiroppyhiroppy removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 24, 2018
@hiroppyhiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil

gireeshpunathil commented Nov 24, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18937

@shisama

shisama commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/18975/

@gireeshpunathil

gireeshpunathil commented Nov 28, 2018

Copy link
Copy Markdown
Member

landed as b02cac5

gireeshpunathil pushed a commit that referenced this pull request Nov 28, 2018
Daiki Arai@gireeshpunathil
lib: convert to Arrow Function
b02cac5
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos pushed a commit that referenced this pull request Nov 28, 2018
Daiki Arai@targos
lib: convert to Arrow Function
e5c85ef
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Daiki Arai@refack
lib: convert to Arrow Function
6e25344
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: nodejs#24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Daiki Arai@BethGriggs
lib: convert to Arrow Function
e5abfe1
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Daiki Arai@rvagg
lib: convert to Arrow Function
db2358e
convert to Arrow Function and test by `./tools/test.py tick-processor`
PR-URL: #24615
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@darai0512@gireeshpunathil@shisama@addaleax@lpinca@cjihrig@joyeecheung@hiroppy@BethGriggs@nodejs-github-bot