Uh oh!
There was an error while loading. Please reload this page.
build: replace -not with ! in find - #24635
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Replace `find -not` usage with `find !` as `-not` is not universally supported. Fixes: nodejs#24634
Trott
commented
Nov 25, 2018
MemberAuthor
👍 here to fast-track |
Trott
commented
Nov 25, 2018
MemberAuthor
gireeshpunathil
approved these changes
Nov 25, 2018
lpinca
approved these changes
Nov 25, 2018
Trott
commented
Nov 25, 2018
MemberAuthor
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18959/ |
richardlau
approved these changes
Nov 25, 2018
gireeshpunathil
commented
Nov 25, 2018
Member
landed as e20be47 |
This was referenced Dec 7, 2018
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Replace `find -not` usage with `find !` as `-not` is not universally supported. Fixes: nodejs#24634 PR-URL: nodejs#24635 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
find -notusage withfind !as-notis not universallysupported.
Fixes: #24634
@nodejs/build-files @rvagg @nodejs/platform-aix
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes