Skip to content

doc: add antsmartian to collaborators - #24655

Closed
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:add-to-docs
Closed

doc: add antsmartian to collaborators#24655
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:add-to-docs

Conversation

@antsmartian

@antsmartianantsmartian commented Nov 26, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #24340

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Nov 26, 2018

Copy link
Copy Markdown
Collaborator

@antsmartian sadly an error occured when I tried to trigger a build :(

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 26, 2018
thefourtheye
thefourtheye suggested changes Nov 26, 2018
View reviewed changes

@thefourtheyethefourtheye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking till the CI infrastructure is available again. Ref: nodejs/build#1594

@antsmartian
antsmartianforce-pushed the add-to-docs branch 2 times, most recently from 9892087 to edacd78CompareNovember 26, 2018 11:36
@richardlaurichardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 26, 2018
Trott
Trott approved these changes Nov 26, 2018
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Trott

Trott commented Nov 28, 2018

Copy link
Copy Markdown
Member

Security release is out and the CI is available again. Hope this can finish soon! @antsmartian@thefourtheye

@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1704/

@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

Landed in c3474f5

antsmartian added a commit that referenced this pull request Nov 28, 2018
@antsmartian
doc: add antsmartian to collaborators
c3474f5
Fixes: #24340
PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@antsmartian

antsmartian commented Nov 28, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks everyone cc @thefourtheye 🎉

@thefourtheyethefourtheye mentioned this pull request Nov 28, 2018
Closed
targos pushed a commit that referenced this pull request Nov 28, 2018
@antsmartian@targos
doc: add antsmartian to collaborators
3288c27
Fixes: #24340
PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current),@BridgeAR
32ee780
Notable Changes:
* util:
The inspection `depth` default is now back at 2.
#24326
* Added new collaborator:
[antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
BridgeAR added a commit that referenced this pull request Dec 5, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current),@BridgeAR
b0273f1
Notable Changes:
* util:
The inspection `depth` default is now back at 2.
#24326
* Added new collaborator:
[antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current),@BridgeAR
2e6e799
Notable Changes:
* util:
The inspection `depth` default is now back at 2.
#24326
* Added new collaborator:
[antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 6, 2018
@BridgeAR
2018-12-06, Version 11.4.0 (Current)
758cb07
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
4f1297f
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR added a commit that referenced this pull request Dec 7, 2018
@BridgeAR
2018-12-07, Version 11.4.0 (Current)
bcef949
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@antsmartian@refack
doc: add antsmartian to collaborators
df4071c
Fixes: nodejs#24340
PR-URL: nodejs#24655
Refs: nodejs#24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@BridgeAR@refack
2018-12-07, Version 11.4.0 (Current)
5912f6d
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
nodejs#23708
* The inspection `depth` default is now back at 2.
nodejs#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
nodejs#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
nodejs#24739
* readline:
* The `readline` module now supports async iterators.
nodejs#23916
* repl:
* The multiline history feature is removed.
nodejs#24804
* tls:
* Added min/max protocol version options.
nodejs#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. nodejs#24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
nodejs#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
nodejs#24677
* The install-tools scripts or now included in the dist.
nodejs#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
nodejs#24655
PR-URL: nodejs#24854
@antsmartian
antsmartian deleted the add-to-docs branch January 29, 2019 16:33
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@antsmartian@BethGriggs
doc: add antsmartian to collaborators
3e4b93a
Fixes: #24340
PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@antsmartian@rvagg
doc: add antsmartian to collaborators
24701de
Fixes: #24340
PR-URL: #24655
Refs: #24340
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
BethGriggs added a commit that referenced this pull request Mar 4, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
1a96d83
Notable Changes
* **doc**
* add antsmartian to collaborators (Anto Aravinth)
[#24655](#24655)
* **http**
* fix error check in Execute() (Brian White)
[#25863](#25863)
* **stream**
* fix end-of-stream for HTTP/2 (Anna Henningsen)
[#24926](#24926)
PR-URL: #26063
BethGriggs added a commit that referenced this pull request Mar 5, 2019
@BethGriggs
2019-03-05, Version 10.15.3 'Dubnium' (LTS)
a52c1ea
Notable Changes
* **doc**
* add antsmartian to collaborators (Anto Aravinth)
[#24655](#24655)
* **http**
* fix error check in Execute() (Brian White)
[#25863](#25863)
* **stream**
* fix end-of-stream for HTTP/2 (Anna Henningsen)
[#24926](#24926)
PR-URL: #26063
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+5 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@thefourtheyethefourtheyethefourtheye approved these changes
@LekoLekoLeko approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@antsmartian@nodejs-github-bot@Trott@apapirovski@thefourtheye@Leko@targos@cjihrig@richardlau@gireeshpunathil@vsemozhetbyt@starkwang@BethGriggs