Skip to content

http2: compat support for nested array headers - #24665

Closed
sebdeckers wants to merge 1 commit into
nodejs:masterfrom
sebdeckers:h2-response-writehead-array
Closed

http2: compat support for nested array headers#24665
sebdeckers wants to merge 1 commit into
nodejs:masterfrom
sebdeckers:h2-response-writehead-array

Conversation

@sebdeckers

@sebdeckerssebdeckers commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

writeHead supports an array of arrays containing header name and values.

Compatibility between http2 & http1 even though this is not documented.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@sebdeckers
http2: compat support for nested array headers
c92863f
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: nodejs#24466
@nodejs-github-bot

nodejs-github-bot commented Nov 27, 2018

Copy link
Copy Markdown
Collaborator

@sebdeckers sadly an error occured when I tried to trigger a build :(

@nodejs-github-botnodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 27, 2018
leeight
leeight reviewed Nov 27, 2018
View reviewed changes
Comment threadlib/internal/http2/compat.js
leeight
leeight reviewed Nov 27, 2018
View reviewed changes
Comment threadlib/internal/http2/compat.js
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19031/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2018
@sebdeckers

sebdeckers commented Nov 29, 2018

Copy link
Copy Markdown
ContributorAuthor

@Trott What does that CI failure mean? I don't see how it relates to the patch.

AssertionError [ERR_ASSERTION]: bootstrapComplete: 1136.0168499946594 >= 1111
at checkNodeTiming (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos17-64/test/sequential/test-performance.js:92:7)

@jasnell

jasnell commented Nov 29, 2018

Copy link
Copy Markdown
Member

That's likely an unrelated flaky failure but we can run again to verify

@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19053/

@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Once more but with feeling: https://ci.nodejs.org/job/node-test-pull-request/19061/

@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Landed in 5dacbf5

@TrottTrott closed this Nov 29, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
@sebdeckers@Trott
http2: add compat support for nested array headers
5dacbf5
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: nodejs#24466
PR-URL: nodejs#24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 29, 2018
@sebdeckers@targos
http2: add compat support for nested array headers
61e0103
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: #24466
PR-URL: #24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@sebdeckers

sebdeckers commented Nov 29, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks for the help, @Trott and everyone who reviewed/commented. 🙇🏻‍♂️

@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@sebdeckers@refack
http2: add compat support for nested array headers
a5705ce
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: nodejs#24466
PR-URL: nodejs#24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@sebdeckers@BethGriggs
http2: add compat support for nested array headers
d12c5a7
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: #24466
PR-URL: #24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@sebdeckers@rvagg
http2: add compat support for nested array headers
8e8035e
writeHead supports an array of arrays containing header name and values.
Compatibility between http2 & http1 even though this is not documented.
Fixes: #24466
PR-URL: #24665
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@leeightleeightleeight left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sebdeckers@nodejs-github-bot@Trott@jasnell@fhinkel@leeight@addaleax@lpinca@cjihrig