Uh oh!
There was an error while loading. Please reload this page.
stream: make async iterator .next() always resolve - #24668
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Nov 27, 2018
Collaborator
@mcollina sadly an error occured when I tried to trigger a build :( |
reconbot
approved these changes
Nov 27, 2018
reconbot
left a comment
Contributor
There was a problem hiding this comment.
Fixes nodejs/readable-stream#387 👏
Uh oh!
There was an error while loading. Please reload this page.
devsnek
approved these changes
Nov 27, 2018
fhinkel
approved these changes
Nov 27, 2018
joyeecheung
approved these changes
Nov 28, 2018
mcollinaforce-pushed
the
stream-iterator-fix
branch
from
November 29, 2018 12:02
be46937 to
4fea207Comparemcollina
commented
Nov 29, 2018
MemberAuthor
BridgeAR
approved these changes
Nov 29, 2018
| } | ||
| assert.strictEqual(e, err); | ||
| })()]); | ||
| })(); |
Member
There was a problem hiding this comment.
Nit: the Promise.all should be obsolete.
| const b = r[Symbol.asyncIterator](); | ||
| const c = b.next(); | ||
| const d = b.next(); |
Member
There was a problem hiding this comment.
Suggestion: verify that c and d are not done yet.
mcollina
commented
Nov 29, 2018
MemberAuthor
Landed in fa1535a |
pullBot
pushed a commit
to SimenB/node
that referenced
this pull request
Nov 29, 2018
See: nodejs/readable-stream#387 PR-URL: nodejs#24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit
that referenced
this pull request
Nov 29, 2018
See: nodejs/readable-stream#387 PR-URL: #24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Dec 7, 2018
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
See: nodejs/readable-stream#387 PR-URL: nodejs#24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit
that referenced
this pull request
Feb 12, 2019
See: nodejs/readable-stream#387 PR-URL: #24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
See: nodejs/readable-stream#387 PR-URL: #24668 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: nodejs/readable-stream#387
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes