Uh oh!
There was an error while loading. Please reload this page.
tools: only sign release if promotion successful - #24669
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
Nov 27, 2018
Collaborator
@rvagg sadly an error occured when I tried to trigger a build :( |
This was referenced Nov 27, 2018
rvagg
commented
Nov 28, 2018
MemberAuthor
Used along with #24670 and the new asset checker with all 4 releases today, a sweet combination and worked well. |
jasnell
approved these changes
Nov 30, 2018
Trott
approved these changes
Dec 1, 2018
Trott
commented
Dec 1, 2018
Member
Member
Landed in f34ca9f |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 1, 2018
Ref: nodejs/build#1596 PR-URL: nodejs#24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Dec 5, 2018
Ref: nodejs/build#1596 PR-URL: #24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Dec 7, 2018
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Ref: nodejs/build#1596 PR-URL: nodejs#24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Feb 12, 2019
Ref: nodejs/build#1596 PR-URL: #24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
rvagg added a commit
that referenced
this pull request
Feb 28, 2019
Ref: nodejs/build#1596 PR-URL: #24669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support nodejs/build#1596, but good practice regardless
@nodejs/releasers @nodejs/build