Skip to content

test: bailout test_threadsafe_function/test - #24714

Merged
Trott merged 1 commit into
nodejs:masterfrom
gireeshpunathil:known_issues2
Dec 1, 2018
Merged

test: bailout test_threadsafe_function/test#24714
Trott merged 1 commit into
nodejs:masterfrom
gireeshpunathil:known_issues2

Conversation

@gireeshpunathil

@gireeshpunathilgireeshpunathil commented Nov 29, 2018

Copy link
Copy Markdown
Member

This is a known failure so mark it such, so that
CI is green / amber while the issue is being progressed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Ref: #23621
Ref: #24607
/cc @Trott

@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1718/pipeline

@nodejs-github-botnodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 29, 2018
@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19028/

@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Waiting for #24712 to land before re-running CI.

@Trott

Trott commented Nov 29, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/19046/

Might need a full CI re-run to incorporate the change from #24712 if that test continues to fail, but I'm not sure about that.

@gireeshpunathil

gireeshpunathil commented Nov 30, 2018

Copy link
Copy Markdown
MemberAuthor
10:26:12 not ok 312 known_issues/test-vm-timeout-escape-nexttick
10:26:12 ---
10:26:12 duration_ms: 7.165
10:26:12 severity: fail
10:26:12 stack: |-
10:26:12 ...

looks like either the resume CI did not pick up the landed commit, or the changes did not have any effect - the test is continued to run and fail. Let me run a full CI to confirm one or the other.

full CI: https://ci.nodejs.org/job/node-test-pull-request/19072/

@Trott

Trott commented Nov 30, 2018•
edited
Loading

Copy link
Copy Markdown
Member

looks like either the resume CI did not pick up the landed commit, or the changes did not have any effect - the test is continued to run and fail. Let me run a full CI to confirm one or the other.

Running "Resume Build" will rebuild from the same commit as the job that is being resumed. It will not rebase against master. So, yeah, running a full CI was the way to go. Now that we've done that...

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19074/ ✔️

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 30, 2018
@Trott

Trott commented Nov 30, 2018

Copy link
Copy Markdown
Member

Collaborators, 👍 here to fast-track.

@gireeshpunathil
test: mark test_threadsafe_function/test as flaky
2b1dd6c
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trott merged commit 2b1dd6c into nodejs:masterDec 1, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@gireeshpunathil@BridgeAR
test: mark test_threadsafe_function/test as flaky
10c2773
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
@gireeshpunathilGabriel Schulhof
test: mark test_threadsafe_function/test as flaky
e0e1ac2
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@gireeshpunathil@refack
test: mark test_threadsafe_function/test as flaky
3dc2aaa
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: nodejs#23621
PR-URL: nodejs#24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2019
@gireeshpunathil@MylesBorins
test: mark test_threadsafe_function/test as flaky
b44bd88
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@gireeshpunathil@BethGriggs
test: mark test_threadsafe_function/test as flaky
a7c72d7
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gireeshpunathil@rvagg
test: mark test_threadsafe_function/test as flaky
36ace72
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: #23621
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gireeshpunathil@rvagg
test: mark test_threadsafe_function/test as flaky
60db455
The test fails consistently on windows-fanned with vs2017.
mark it as flaky while the issue is being progressed, and
to keep CI green / amber.
Ref: #23621
Backport-PR-URL: #25002
PR-URL: #24714
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 26, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@gabrielschulhofgabrielschulhofAwaiting requested review from gabrielschulhof

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.node-apiIssues and PRs related to the Node-API.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gireeshpunathil@nodejs-github-bot@Trott@jasnell@BethGriggs