Skip to content

test: show stdout and stderr in test-cli-syntax when it fails - #24720

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:cli-error
Closed

test: show stdout and stderr in test-cli-syntax when it fails#24720
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:cli-error

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Nov 29, 2018

Copy link
Copy Markdown
Member

To help debugging the flake with the log from the CI.

Refs: #24403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@joyeecheung
test: show stdout and stderr in test-cli-syntax when it fails
45abbe4
To help debugging the flake with the log from the CI.
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1723/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 29, 2018
@joyeecheung

joyeecheung commented Nov 29, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/19043/
Stress Test: https://ci.nodejs.org/job/node-stress-single-test/2116/

@joyeecheung

joyeecheung commented Nov 29, 2018

Copy link
Copy Markdown
MemberAuthor

There seems to be something off with another test case: err.code is not always set when the process fails, somehow we got a null instead of a number https://ci.nodejs.org/job/node-stress-single-test/2116/nodes=freebsd11-x64/testReport/junit/(root)/test121/parallel_test_cli_syntax/

@joyeecheung

joyeecheung commented Nov 29, 2018

Copy link
Copy Markdown
MemberAuthor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19067/

@Trott

Trott commented Nov 29, 2018

Copy link
Copy Markdown
Member

Resume Build won't rebase so you'll get a lot of that irksome known_issues/test-vm-timeout-escape-nexttick on Raspberry Pi. Here's a rebuild for Raspberry Pi only so that it rebases and gets the status file change marking that test as flaky: https://ci.nodejs.org/job/node-test-commit-arm-fanned/4761/

@joyeecheungjoyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 1, 2018
@joyeecheung@Trott
test: show stdout and stderr in test-cli-syntax when it fails
3fb627b
To help debugging the flake with the log from the CI.
PR-URL: nodejs#24720
Refs: nodejs#24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott

Trott commented Dec 1, 2018

Copy link
Copy Markdown
Member

Landed in 3fb627b

@TrottTrott closed this Dec 1, 2018
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@joyeecheung@BridgeAR
test: show stdout and stderr in test-cli-syntax when it fails
085f5b6
To help debugging the flake with the log from the CI.
PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeARBridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@joyeecheung@refack
test: show stdout and stderr in test-cli-syntax when it fails
b298ec3
To help debugging the flake with the log from the CI.
PR-URL: nodejs#24720
Refs: nodejs#24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@joyeecheung@BethGriggs
test: show stdout and stderr in test-cli-syntax when it fails
46e37ad
To help debugging the flake with the log from the CI.
PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@joyeecheung@rvagg
test: show stdout and stderr in test-cli-syntax when it fails
850a1af
To help debugging the flake with the log from the CI.
PR-URL: #24720
Refs: #24403
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@joyeecheung@nodejs-github-bot@Trott@danbev@addaleax@lpinca@richardlau@BethGriggs