Uh oh!
There was an error while loading. Please reload this page.
test: prepare test/pseudo-tty/testcfg.py for Python 3 - #24791
Closed
cclauss wants to merge 1 commit into
Closed
Conversation
cclaussforce-pushed
the
Py3-for-test_pseudo-tty-testcfg.py
branch
from
December 3, 2018 08:41
8b90890 to
2abb72eCompareTrott
approved these changes
Dec 7, 2018
Member
Trott
commented
Dec 7, 2018
Member
@nodejs/python This could use another reviewer. |
richardlau
approved these changes
Dec 7, 2018
Trott
commented
Dec 7, 2018
Member
Landed in 6028f70 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 7, 2018
PR-URL: nodejs#24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24791 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
label: python
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes