Uh oh!
There was an error while loading. Please reload this page.
tools: prepare tools/install.py for Python 3 - #24800
Closed
cclauss wants to merge 1 commit into
Closed
Conversation
Trott
approved these changes
Dec 6, 2018
Trott
commented
Dec 6, 2018
Member
Trott
commented
Dec 6, 2018
Member
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19267/ |
Trott
commented
Dec 6, 2018
Member
@nodejs/python This could use one more review. |
addaleax
approved these changes
Dec 6, 2018
addaleax
commented
Dec 6, 2018
Member
Landed in b8fbe69 |
addaleax pushed a commit
that referenced
this pull request
Dec 6, 2018
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Dec 6, 2018
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BridgeAR pushed a commit
that referenced
this pull request
Dec 7, 2018
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Dec 7, 2018
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes