Uh oh!
There was an error while loading. Please reload this page.
inspector, tracing: Make sure messages are sent on a main thread - #24814
Conversation
eugeneo
commented
Dec 3, 2018
@ofrobots |
ofrobots
commented
Dec 3, 2018
Trott
commented
Dec 4, 2018
eugeneo
commented
Dec 4, 2018
Looks like there's a race condition that surfaces on Windows. |
eugeneo
commented
Jan 6, 2019
CI is now passing: https://ci.nodejs.org/job/node-test-pull-request/19946/ I will update the commit title and will rebase the change. I also have a follow-up CL that fixes the problem that the bad test case identified. |
Trott
commented
Jan 6, 2019
@nodejs/v8-inspector @nodejs/trace-events |
Any news on when this PR could be merged (as well was #24945) ? Currently the inspector based |
eugeneo
commented
Jan 30, 2019
eugeneo
commented
Jan 30, 2019
The only CI failure is coming from a flaky test that only fails on a single bot. |
Fixes: #23185
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes