trace_events: fix trace events JS API not writing traces by kjin · Pull Request #24945 · nodejs/node

kjin · 2018-12-10T21:10:17Z

~~I believe Inspector-based tracing probably faces the same issue, but I wasn't yet able to verify it because of a possibly unrelated V8 issue. So this PR only fixes the JS API.~~ (edit: it seems that this does not affect inspector as it uses its own trace writer)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

addaleax · 2018-12-10T23:41:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19407/

kjin · 2018-12-10T23:49:36Z

@addaleax BTW, should a PR like this have a src or a tracing prefix? I wasn't sure what to put.

addaleax · 2018-12-11T00:04:04Z

@kjin I think tracing: would be good, yes… I don’t think it would be an issue if you keep it though :)

joyeecheung · 2018-12-11T00:59:12Z

@kjin Currently core-validate-commit only supports trace_events

https://github.com/nodejs/core-validate-commit/blob/b3a89a152e5c144d49918551fdc3a5bad36f73b0/lib/rules/subsystem.js#L61

richardlau · 2018-12-11T01:20:58Z

Does the test in the first commit fail unless the second commit is applied? If so then we probably want to squash on landing (or swap the ordering) to avoid issues with future git bisects.

kjin · 2018-12-11T01:36:01Z

@joyeecheung I've seen a mix of tracing and trace_events, I assumed the former would apply to C++ and the latter would apply to the JS API. I'll try to use trace_events

@richardlau Yes, it does. Good idea, I'll do that. (It looks like the GitHub UI still shows them in the former order, though)

@addaleax I fixed an issue in my test which should resolve the currently failing CI.

kjin · 2018-12-11T18:19:33Z

@joyeecheung It looks like using trace_events is causing the commit message linter to emit an error. Do you know why this might be the case?

richardlau · 2018-12-11T18:23:44Z

@joyeecheung It looks like using trace_events is causing the commit message linter to emit an error. Do you know why this might be the case?

@kjin You missed off the : after trace_events.

kjin · 2018-12-11T18:27:23Z

@richardlau Thanks for the catch (again) :)

addaleax · 2018-12-15T20:47:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19568/

Trott

CI failures on Windows, AIX, and SmartOS all seem to be relevant. (Collaborators, feel free to dismiss this review once addressed. I'm only leaving this here to someone doesn't land this in error.)

kjin · 2018-12-18T01:21:02Z

On Windows there seems to be an issue with the temporary directory not being refreshed due to being a locked resource (EBUSY). I'm working through this and should hopefully get a fix in within the next day.

kjin · 2018-12-18T21:33:13Z

@Trott I believe I've fixed the issue (tested it on Windows). (It was because my test was trying to delete the temp directory when it was the parent process's cwd)

Trott · 2018-12-22T14:48:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19750/ ✔️

test fixed; could use a re-review or two, though

kjin · 2019-01-02T23:31:24Z

I've rebased to resolve conflicts. cc @addaleax

vmarchaud · 2019-01-30T20:10:22Z

@kjin could you rebase again so this PR can go forward ? Thanks !

kjin · 2019-02-05T23:28:56Z

@vmarchaud I've rebased the PR!

ofrobots · 2019-02-14T02:25:14Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/20772/

The Trace Events JS API isn't functional if none of --trace-events-enabled or --trace-event-categories is passed as a CLI argument. This commit fixes that. In addition, we currently don't test the trace_events JS API in the case where no CLI args are provided. This commit adds that test. Fixesnodejs#24944

ofrobots · 2019-02-14T19:23:14Z

The CI is green and this is good to go. However, I think the commits needs to be squashed. The latter is not a test-only change is dependent/overlapping with the former.

ofrobots · 2019-02-14T20:10:54Z

Landed in 582c0d5

The Trace Events JS API isn't functional if none of --trace-events-enabled or --trace-event-categories is passed as a CLI argument. This commit fixes that. In addition, we currently don't test the trace_events JS API in the casewhere no CLI args are provided. This commit adds that test. Fixes#24944 PR-URL: #24945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Dec 10, 2018

addaleax added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Dec 10, 2018

addaleax approved these changes Dec 10, 2018
View reviewed changes

Comment threadsrc/node_internals.h Outdated
Comment threadsrc/node_trace_events.cc Outdated

kjin force-pushed the trace-events-fix branch from b2c0fd4 to 616d9a9Compare December 10, 2018 22:10

addaleax approved these changes Dec 10, 2018
View reviewed changes

kjin force-pushed the trace-events-fix branch from 616d9a9 to 5233f8bCompare December 11, 2018 01:35

kjin changed the title ~~src: fix trace events JS API not writing traces~~trace_events: fix trace events JS API not writing tracesDec 11, 2018

jasnell approved these changes Dec 11, 2018
View reviewed changes

cjihrig approved these changes Dec 11, 2018
View reviewed changes

kjin force-pushed the trace-events-fix branch from 5233f8b to 24ce0e4Compare December 11, 2018 18:27

Trott previously requested changes Dec 16, 2018
View reviewed changes

kjin force-pushed the trace-events-fix branch from 24ce0e4 to fde17fdCompare December 18, 2018 21:31

kjin force-pushed the trace-events-fix branch from fde17fd to 14796a8Compare January 2, 2019 23:30

vmarchaud mentioned this pull request Jan 26, 2019
inspector, tracing: Make sure messages are sent on a main thread #24814
Merged
2 tasks

kjin force-pushed the trace-events-fix branch from 14796a8 to eff875bCompare February 5, 2019 23:28

kjin force-pushed the trace-events-fix branch from eff875b to 6d6d36fCompare February 14, 2019 19:23

ofrobots approved these changes Feb 14, 2019
View reviewed changes

ofrobots closed this Feb 14, 2019

BridgeAR mentioned this pull request Feb 26, 2019
v11.11.0 proposal #26322
Merged

Uh oh!

Uh oh!

Conversation

kjin commented Dec 10, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

addaleax commented Dec 10, 2018

Uh oh!

kjin commented Dec 10, 2018

Uh oh!

addaleax commented Dec 11, 2018

Uh oh!

joyeecheung commented Dec 11, 2018

Uh oh!

richardlau commented Dec 11, 2018

Uh oh!

kjin commented Dec 11, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjin commented Dec 11, 2018

Uh oh!

richardlau commented Dec 11, 2018

Uh oh!

kjin commented Dec 11, 2018

Uh oh!

addaleax commented Dec 15, 2018

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

kjin commented Dec 18, 2018

Uh oh!

kjin commented Dec 18, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 22, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kjin commented Jan 2, 2019

Uh oh!

vmarchaud commented Jan 30, 2019

Uh oh!

kjin commented Feb 5, 2019

Uh oh!

ofrobots commented Feb 14, 2019

Uh oh!

ofrobots commented Feb 14, 2019

Uh oh!

ofrobots commented Feb 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

kjin commented Dec 10, 2018•
edited
Loading

kjin commented Dec 11, 2018•
edited
Loading

kjin commented Dec 18, 2018•
edited
Loading

Trott commented Dec 22, 2018•
edited
Loading