test: adding history regression test case by antsmartian · Pull Request #24843 · nodejs/node

antsmartian · 2018-12-05T02:45:40Z

Recently added mulitline caused a issue in history navigation ref: #24385

Fundamentally, we don't had a test case for navigation till now, the one I see here: https://github.com/nodejs/node/blob/master/test/parallel/test-repl-persistent-history.js#L97, just tests one level navigation.

cc @nodejs/repl @BridgeAR

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot · 2018-12-05T02:45:42Z

@antsmartian sadly an error occured when I tried to trigger a build :(

antsmartian · 2018-12-05T02:47:04Z

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1836/

antsmartian · 2018-12-07T15:20:24Z

Rebuild CI Lite : https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1862/

antsmartian · 2018-12-07T15:30:29Z

@BridgeAR ping...

antsmartian · 2018-12-12T15:37:51Z

@nodejs/repl @BridgeAR Gentle remainder 🔉

BridgeAR · 2018-12-12T15:53:24Z

I suggest to add one more UP and one more DOWN so we reach the end of the list in both cases.

Yeah, taken care of this. Guess should be good now.. cc @BridgeAR

antsmartian · 2018-12-13T15:00:45Z

CI Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1928/

antsmartian · 2018-12-14T13:58:56Z

@BridgeAR Can you please just have a look now, have addressed your comments and I wanted to take your review once before I land this to master.

BridgeAR · 2018-12-14T14:07:25Z

Still LG but please run a regular CI

antsmartian · 2018-12-14T14:24:55Z

Yeah sure, thanks much @BridgeAR.

antsmartian · 2018-12-15T03:54:13Z

CI : https://ci.nodejs.org/job/node-test-pull-request/19553/

Trott · 2018-12-15T05:53:58Z

Landed in 0bf7d41

PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

antsmartian · 2018-12-15T08:07:11Z

Thanks @Trott

PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2018

BridgeAR reviewed Dec 5, 2018
View reviewed changes

Comment threadtest/parallel/test-repl-history-navigation.js Outdated
Comment threadtest/parallel/test-repl-history-navigation.js Outdated

antsmartian force-pushed the repl-history-test-case branch from 912aa88 to 078dfa8Compare December 7, 2018 14:28

BridgeAR approved these changes Dec 12, 2018
View reviewed changes

test: adding history regression test case
9d7ce13

antsmartian force-pushed the repl-history-test-case branch from 078dfa8 to 9d7ce13Compare December 13, 2018 14:58

Trott closed this Dec 15, 2018

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 15, 2018
test: adding history regression test case
0bf7d41
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

antsmartian deleted the repl-history-test-case branch December 15, 2018 10:55

BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
test: adding history regression test case
eb9e6e6
PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs mentioned this pull request Dec 18, 2018
V11.5.0 proposal #25102
Merged

beevelop mentioned this pull request Dec 18, 2018
2018-12-18 Version 11.5.0 (Current) @BethGriggs beevelop/docker-android-nodejs#272
Closed

sagitsofan pushed a commit to sagitsofan/node that referenced this pull request Dec 24, 2018
test: adding history regression test case
6061d24
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
test: adding history regression test case
7739375
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
test: adding history regression test case
54d7e82
PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BethGriggs added the land-on-v10.x label Feb 12, 2019

BethGriggs mentioned this pull request Feb 12, 2019
v10.15.3 proposal #26063
Merged

BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
test: adding history regression test case
d7a6218
PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

rvagg pushed a commit that referenced this pull request Feb 28, 2019
test: adding history regression test case
1348cd5
PR-URL: #24843 Refs: #24385 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Uh oh!

Uh oh!

Conversation

antsmartian commented Dec 5, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Dec 5, 2018

Uh oh!

antsmartian commented Dec 5, 2018

Uh oh!

Uh oh!

Uh oh!

antsmartian commented Dec 7, 2018

Uh oh!

antsmartian commented Dec 7, 2018

Uh oh!

antsmartian commented Dec 12, 2018

Uh oh!

BridgeARDec 12, 2018

Choose a reason for hiding this comment

Uh oh!

antsmartianDec 13, 2018

Choose a reason for hiding this comment

Uh oh!

antsmartian commented Dec 13, 2018

Uh oh!

antsmartian commented Dec 14, 2018

Uh oh!

BridgeAR commented Dec 14, 2018

Uh oh!

antsmartian commented Dec 14, 2018

Uh oh!

antsmartian commented Dec 15, 2018

Uh oh!

Trott commented Dec 15, 2018

Uh oh!

antsmartian commented Dec 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

antsmartian commented Dec 5, 2018•
edited
Loading